Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: cc/input/browser_controls_offset_manager.h

Issue 2442473002: Controls offsets computed if either top or bottom are showing (Closed)
Patch Set: rebase & better implementation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/input/browser_controls_offset_manager.h
diff --git a/cc/input/browser_controls_offset_manager.h b/cc/input/browser_controls_offset_manager.h
index 1daa8e95f3a0d0a1920fdce93c1da563d41bb5de..aa35f52dbb87b9f1025a07d48362a847e90069db 100644
--- a/cc/input/browser_controls_offset_manager.h
+++ b/cc/input/browser_controls_offset_manager.h
@@ -80,8 +80,6 @@ class CC_EXPORT BrowserControlsOffsetManager
void StartAnimationIfNecessary();
bool IsAnimationComplete(float new_ratio);
void ResetBaseline();
- // Offset computation regardless of top or bottom control state.
- float ContentOffsetInternal() const;
// The client manages the lifecycle of this.
BrowserControlsOffsetManagerClient* client_;
@@ -97,8 +95,9 @@ class CC_EXPORT BrowserControlsOffsetManager
// Accumulated scroll delta since last baseline reset
float accumulated_scroll_delta_;
- // Content offset when last baseline reset occurred
- float baseline_content_offset_;
+ // Content offset when last baseline reset occurred.
+ float baseline_top_content_offset_;
+ float baseline_bottom_content_offset_;
// The percent height of the visible control such that it must be shown
// when the user stops the scroll.
« no previous file with comments | « no previous file | cc/input/browser_controls_offset_manager.cc » ('j') | cc/input/browser_controls_offset_manager_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698