Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2442463002: Split out error codes into separate files (Closed)

Created:
4 years, 2 months ago by Brian Wilkerson
Modified:
4 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+854 lines, -804 lines) Patch
M pkg/analyzer/lib/error/error.dart View 3 chunks +12 lines, -3 lines 0 comments Download
A pkg/analyzer/lib/src/analysis_options/error/option_codes.dart View 1 chunk +114 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/dart/error/hint_codes.dart View 1 chunk +571 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/dart/error/lint_codes.dart View 1 chunk +25 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/dart/error/todo_codes.dart View 1 chunk +45 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/error/codes.dart View 3 chunks +5 lines, -801 lines 0 comments Download
A pkg/analyzer/lib/src/html/error/html_codes.dart View 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 2 months ago (2016-10-20 15:36:23 UTC) #2
scheglov
LGTM
4 years, 2 months ago (2016-10-20 15:39:15 UTC) #3
Brian Wilkerson
4 years, 2 months ago (2016-10-20 15:40:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9f0e4e1162298625c2d90213076c3dcac4dc41a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698