cc: Add back a benchmark category trace for counting renderer frames

cc: Add back a benchmark category trace for counting renderer frames

When deleting DelegatingRenderer::SwapBuffers I failed to notice that
the TRACE_EVENT in there had the benchmark category. This category
is used by perf tests, and without that event they had no way to count
the number of renderer frames produced.

This adds benchmark to the DrawLayers trace event in LayerTreeHostImpl
instead and points the perf tests at that. Also removes the benchmark
category from the GLRenderer and SoftwareRenderer classes as they are
never used in the renderer and are not used for perf tests (tools/ no
longer refers to the name "SwapBuffers" for perf tests).

R=enne@chromium.org
TBR=dtu
BUG=656947
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/7607802c76a4a0b826d22807213e981025ec734b
Cr-Commit-Position: refs/heads/master@{#426952}

[danakj, 2016-10-20 22:23:37]

Description was changed from

==========
cc: Add back a benchmark category trace for counting renderer frames

When deleting DelegatingRenderer::SwapBuffers I failed to notice that
the TRACE_EVENT in there had the benchmark category. This category
is used by perf tests, and without that event they had no way to count
the number of renderer frames produced.

This adds benchmark to the DrawLayers trace event in LayerTreeHostImpl
instead and points the perf tests at that. Also removes the benchmark
category from the GLRenderer and SoftwareRenderer classes as they are
never used in the renderer and are not used for perf tests (tools/ no
longer refers to the name "SwapBuffers" for perf tests).

R=enne@chromium.org
BUG=656947
==========

to

==========
cc: Add back a benchmark category trace for counting renderer frames

When deleting DelegatingRenderer::SwapBuffers I failed to notice that
the TRACE_EVENT in there had the benchmark category. This category
is used by perf tests, and without that event they had no way to count
the number of renderer frames produced.

This adds benchmark to the DrawLayers trace event in LayerTreeHostImpl
instead and points the perf tests at that. Also removes the benchmark
category from the GLRenderer and SoftwareRenderer classes as they are
never used in the renderer and are not used for perf tests (tools/ no
longer refers to the name "SwapBuffers" for perf tests).

R=enne@chromium.org
BUG=656947
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-10-20 22:24:06]

danakj@chromium.org changed reviewers:
+ dtu@chromium.org

[danakj, 2016-10-20 22:24:06]

dtu: tools/perf
enne: cc

[danakj, 2016-10-20 22:25:43]

https://codereview.chromium.org/2442453003/diff/1/tools/perf/metrics/timeline.py
File tools/perf/metrics/timeline.py (right):

https://codereview.chromium.org/2442453003/diff/1/tools/perf/metrics/timeline...
tools/perf/metrics/timeline.py:103: FrameTraceName = "::DrawLayers"
Should this be LayerTreeHostImpl::DrawLayers maybe? That'd be extra trace-able.
I'll do that.

[danakj, 2016-10-20 22:26:07]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 22:26:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2016-10-20 22:32:59]

lgtm

[commit-bot: I haz the power, 2016-10-21 00:05:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 00:05:31]

Dry run: This issue passed the CQ dry run.

[danakj, 2016-10-21 22:03:42]

danakj@chromium.org changed reviewers:
+ sullivan@chromium.org

[danakj, 2016-10-21 22:03:43]

+sullivan@chromium.org for tools/perf dtu appears unavail

[danakj, 2016-10-21 23:28:19]

I can't find a perf/ OWNER and this is making bots fail to collect data. Some
data > no data. So I'm going to TBR and follow up if I need to change anything.

[danakj, 2016-10-21 23:28:33]

Description was changed from

==========
cc: Add back a benchmark category trace for counting renderer frames

When deleting DelegatingRenderer::SwapBuffers I failed to notice that
the TRACE_EVENT in there had the benchmark category. This category
is used by perf tests, and without that event they had no way to count
the number of renderer frames produced.

This adds benchmark to the DrawLayers trace event in LayerTreeHostImpl
instead and points the perf tests at that. Also removes the benchmark
category from the GLRenderer and SoftwareRenderer classes as they are
never used in the renderer and are not used for perf tests (tools/ no
longer refers to the name "SwapBuffers" for perf tests).

R=enne@chromium.org
BUG=656947
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Add back a benchmark category trace for counting renderer frames

When deleting DelegatingRenderer::SwapBuffers I failed to notice that
the TRACE_EVENT in there had the benchmark category. This category
is used by perf tests, and without that event they had no way to count
the number of renderer frames produced.

This adds benchmark to the DrawLayers trace event in LayerTreeHostImpl
instead and points the perf tests at that. Also removes the benchmark
category from the GLRenderer and SoftwareRenderer classes as they are
never used in the renderer and are not used for perf tests (tools/ no
longer refers to the name "SwapBuffers" for perf tests).

R=enne@chromium.org
TBR=dtu
BUG=656947
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-10-21 23:28:37]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-10-21 23:29:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 02:21:31]

Description was changed from

==========
cc: Add back a benchmark category trace for counting renderer frames

When deleting DelegatingRenderer::SwapBuffers I failed to notice that
the TRACE_EVENT in there had the benchmark category. This category
is used by perf tests, and without that event they had no way to count
the number of renderer frames produced.

This adds benchmark to the DrawLayers trace event in LayerTreeHostImpl
instead and points the perf tests at that. Also removes the benchmark
category from the GLRenderer and SoftwareRenderer classes as they are
never used in the renderer and are not used for perf tests (tools/ no
longer refers to the name "SwapBuffers" for perf tests).

R=enne@chromium.org
TBR=dtu
BUG=656947
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Add back a benchmark category trace for counting renderer frames

When deleting DelegatingRenderer::SwapBuffers I failed to notice that
the TRACE_EVENT in there had the benchmark category. This category
is used by perf tests, and without that event they had no way to count
the number of renderer frames produced.

This adds benchmark to the DrawLayers trace event in LayerTreeHostImpl
instead and points the perf tests at that. Also removes the benchmark
category from the GLRenderer and SoftwareRenderer classes as they are
never used in the renderer and are not used for perf tests (tools/ no
longer refers to the name "SwapBuffers" for perf tests).

R=enne@chromium.org
TBR=dtu
BUG=656947
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-10-22 02:21:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-22 02:26:14]

Description was changed from

==========
cc: Add back a benchmark category trace for counting renderer frames

When deleting DelegatingRenderer::SwapBuffers I failed to notice that
the TRACE_EVENT in there had the benchmark category. This category
is used by perf tests, and without that event they had no way to count
the number of renderer frames produced.

This adds benchmark to the DrawLayers trace event in LayerTreeHostImpl
instead and points the perf tests at that. Also removes the benchmark
category from the GLRenderer and SoftwareRenderer classes as they are
never used in the renderer and are not used for perf tests (tools/ no
longer refers to the name "SwapBuffers" for perf tests).

R=enne@chromium.org
TBR=dtu
BUG=656947
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Add back a benchmark category trace for counting renderer frames

When deleting DelegatingRenderer::SwapBuffers I failed to notice that
the TRACE_EVENT in there had the benchmark category. This category
is used by perf tests, and without that event they had no way to count
the number of renderer frames produced.

This adds benchmark to the DrawLayers trace event in LayerTreeHostImpl
instead and points the perf tests at that. Also removes the benchmark
category from the GLRenderer and SoftwareRenderer classes as they are
never used in the renderer and are not used for perf tests (tools/ no
longer refers to the name "SwapBuffers" for perf tests).

R=enne@chromium.org
TBR=dtu
BUG=656947
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/7607802c76a4a0b826d22807213e981025ec734b
Cr-Commit-Position: refs/heads/master@{#426952}
==========

[commit-bot: I haz the power, 2016-10-22 02:26:14]

Patchset 2 (id:??) landed as
https://crrev.com/7607802c76a4a0b826d22807213e981025ec734b
Cr-Commit-Position: refs/heads/master@{#426952}

[sullivan, 2016-10-22 13:54:04]

lgtm, but this may need to be disabled on the reference build until it rolls
past these changes being available in chrome stable.