Pass SharedBuffer by reference to DeferredImageDecoder::setData()

Source/platform/graphics/DeferredImageDecoder.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 99 matching lines @@
         // ImageFrameGenerator has the latest known alpha state. There will
         // be a performance boost if this frame is opaque.
         m_lazyDecodedFrames[index]->setHasAlpha(m_frameGenerator->hasAlpha(index));
         return m_lazyDecodedFrames[index].get();
     }
     if (m_actualDecoder)
         return m_actualDecoder->frameBufferAtIndex(index);
     return 0;
 }
 
-void DeferredImageDecoder::setData(SharedBuffer* data, bool allDataReceived)
+void DeferredImageDecoder::setData(SharedBuffer& data, bool allDataReceived)
 {
     if (m_actualDecoder) {
-        const bool firstData = !m_data && data;
-        const bool moreData = data && data->size() > m_lastDataSize;
+        const bool firstData = !m_data;
+        const bool moreData = data.size() > m_lastDataSize;
         m_dataChanged = firstData || moreData;
-        m_data = data;
-        m_lastDataSize = data->size();

[Inactive, 2014/04/20 13:16:51]

There was no null check here.

+        m_data = RefPtr<SharedBuffer>(data);
+        m_lastDataSize = data.size();
         m_allDataReceived = allDataReceived;
-        m_actualDecoder->setData(data, allDataReceived);
+        m_actualDecoder->setData(&data, allDataReceived);
         prepareLazyDecodedFrames();
     }
 
     if (m_frameGenerator)
-        m_frameGenerator->setData(data, allDataReceived);
+        m_frameGenerator->setData(&data, allDataReceived);
 }
 
 bool DeferredImageDecoder::isSizeAvailable()
 {
     // m_actualDecoder is 0 only if image decoding is deferred and that
     // means image header decoded successfully and size is available.
     return m_actualDecoder ? m_actualDecoder->isSizeAvailable() : true;
 }
 
 IntSize DeferredImageDecoder::size() const
@@ skipping 181 matching lines @@
     return bitmap;
 }
 
 bool DeferredImageDecoder::hotSpot(IntPoint& hotSpot) const
 {
     // TODO: Implement.
     return m_actualDecoder ? m_actualDecoder->hotSpot(hotSpot) : false;
 }
 
 } // namespace WebCore