Simplify ObjectPaintInvalidatorW/C::computePaintInvalidationReason()

Simplify ObjectPaintInvalidatorW/C::computePaintInvalidationReason()

Now it returns PaintInvalidationBoundsChange instead of
PaintInvalidationIncremental when bounds change for non-LayoutBox.
Then we don't need to override PaintInvalidationIncremental with
PaintInvalidationFull in ObjectPaintInvalidatorWithContext::
invalidatePaintIfNeeded().

About layout test changes:
- Some test no longer produce PaintInvalidationSelection invalidations
  when the object is doing full paint invalidation;
- Some "full" invalidations are now "bounds change" invalidations.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/85d28b117fc977f85fc4a23ec8ac9e3348235572
Cr-Commit-Position: refs/heads/master@{#427213}

[Xianzhu, 2016-10-24 18:12:41]

Description was changed from

==========
Simplify ObjectPaintInvalidatorW/C::computePaintInvalidationReason()

Now it returns PaintInvalidationBoundsChange instead of
PaintInvalidationIncremental when bounds change for non-LayoutBox.
Then we don't need to override PaintInvalidationIncremental with
PaintInvalidationFull in ObjectPaintInvalidatorWithContext::
invalidatePaintIfNeeded().

About layout test changes:
- Some test no longer produce PaintInvalidationSelection invalidations
  when the object is doing full paint invalidation;
- Some "full" invalidations are now "bounds change" invalidations.
==========

to

==========
Simplify ObjectPaintInvalidatorW/C::computePaintInvalidationReason()

Now it returns PaintInvalidationBoundsChange instead of
PaintInvalidationIncremental when bounds change for non-LayoutBox.
Then we don't need to override PaintInvalidationIncremental with
PaintInvalidationFull in ObjectPaintInvalidatorWithContext::
invalidatePaintIfNeeded().

About layout test changes:
- Some test no longer produce PaintInvalidationSelection invalidations
  when the object is doing full paint invalidation;
- Some "full" invalidations are now "bounds change" invalidations.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-10-24 18:12:43]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 18:13:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-10-24 18:23:49]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[Xianzhu, 2016-10-24 18:23:49]

Ptal.

https://codereview.chromium.org/2442383002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp (left):

https://codereview.chromium.org/2442383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp:506: 
There would be no change of test results and this CL would be a pure refactor if
I had put the above lines to above invalidateSelectionIfNeeded() and used
PaintInvalidationBoundsChanged instead of PaintInvalidationFull in
https://codereview.chromium.org/2423513002/.

[commit-bot: I haz the power, 2016-10-24 19:41:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 19:41:49]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[pdr., 2016-10-24 21:10:49]

LGTM

One small question: is the change to js-late-clipPath-creation-expected.png
expected?

There are a few failures on the bots. If they are the same flavor as the ones
you updated, feel free to update and land.

[Xianzhu, 2016-10-24 21:30:20]

On 2016/10/24 21:10:49, pdr. wrote:
> LGTM
> 
> One small question: is the change to js-late-clipPath-creation-expected.png
> expected?
 
This test didn't produce image failure before I rebaselined it locally. Perhaps
the png file was changed just some metadata when it was re-generated by
--reset-results. The new baseline also didn't fail on bots. Will exclude it from
the patch. 

> There are a few failures on the bots. If they are the same flavor as the ones
> you updated, feel free to update and land.

On Linux bots, there was one additional failed test
compositing/squashing/selection-repaint-with-gaps.html which I didn't try and
rebaseline.
On other bots, the failures are about the same tests that have been rebaselined
on Linux.

Will rebaseline-cl locally and land.

[Xianzhu, 2016-10-24 21:48:59]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-10-24 21:49:00]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2442383002/#ps20001
(title: "rebaseline-cl")

[commit-bot: I haz the power, 2016-10-24 21:49:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 01:27:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-25 01:29:15]

Description was changed from

==========
Simplify ObjectPaintInvalidatorW/C::computePaintInvalidationReason()

Now it returns PaintInvalidationBoundsChange instead of
PaintInvalidationIncremental when bounds change for non-LayoutBox.
Then we don't need to override PaintInvalidationIncremental with
PaintInvalidationFull in ObjectPaintInvalidatorWithContext::
invalidatePaintIfNeeded().

About layout test changes:
- Some test no longer produce PaintInvalidationSelection invalidations
  when the object is doing full paint invalidation;
- Some "full" invalidations are now "bounds change" invalidations.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Simplify ObjectPaintInvalidatorW/C::computePaintInvalidationReason()

Now it returns PaintInvalidationBoundsChange instead of
PaintInvalidationIncremental when bounds change for non-LayoutBox.
Then we don't need to override PaintInvalidationIncremental with
PaintInvalidationFull in ObjectPaintInvalidatorWithContext::
invalidatePaintIfNeeded().

About layout test changes:
- Some test no longer produce PaintInvalidationSelection invalidations
  when the object is doing full paint invalidation;
- Some "full" invalidations are now "bounds change" invalidations.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/85d28b117fc977f85fc4a23ec8ac9e3348235572
Cr-Commit-Position: refs/heads/master@{#427213}
==========

[commit-bot: I haz the power, 2016-10-25 01:29:16]

Patchset 2 (id:??) landed as
https://crrev.com/85d28b117fc977f85fc4a23ec8ac9e3348235572
Cr-Commit-Position: refs/heads/master@{#427213}