|
|
Created:
4 years, 1 month ago by gsathya Modified:
4 years, 1 month ago Reviewers:
adamk CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[promises] remove if kPending check
FulfillPromise is always called when a promise is in a pending state
which makes this check redundant.
Committed: https://crrev.com/d390e11e02dd94d6602c4beb5baf61fd210ca761
Cr-Commit-Position: refs/heads/master@{#40556}
Patch Set 1 #
Created: 4 years, 1 month ago
Messages
Total messages: 14 (9 generated)
The CQ bit was checked by gsathya@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
gsathya@chromium.org changed reviewers: + adamk@chromium.org
Description was changed from ========== [promises] remove if kPending check ========== to ========== [promises] remove if kPending check FulfillPromise is always called when a promise is in a pending state which makes this check redundant. ==========
lgtm Looks like this is an Assert in the spec, so seems reasonable that this is a no-op in our code.
The CQ bit was checked by gsathya@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [promises] remove if kPending check FulfillPromise is always called when a promise is in a pending state which makes this check redundant. ========== to ========== [promises] remove if kPending check FulfillPromise is always called when a promise is in a pending state which makes this check redundant. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [promises] remove if kPending check FulfillPromise is always called when a promise is in a pending state which makes this check redundant. ========== to ========== [promises] remove if kPending check FulfillPromise is always called when a promise is in a pending state which makes this check redundant. Committed: https://crrev.com/d390e11e02dd94d6602c4beb5baf61fd210ca761 Cr-Commit-Position: refs/heads/master@{#40556} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d390e11e02dd94d6602c4beb5baf61fd210ca761 Cr-Commit-Position: refs/heads/master@{#40556} |