Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 2442373002: [promises] remove if kPending check (Closed)

Created:
4 years, 1 month ago by gsathya
Modified:
4 years, 1 month ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] remove if kPending check FulfillPromise is always called when a promise is in a pending state which makes this check redundant. Committed: https://crrev.com/d390e11e02dd94d6602c4beb5baf61fd210ca761 Cr-Commit-Position: refs/heads/master@{#40556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M src/js/promise.js View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
gsathya
4 years, 1 month ago (2016-10-25 08:24:42 UTC) #6
adamk
lgtm Looks like this is an Assert in the spec, so seems reasonable that this ...
4 years, 1 month ago (2016-10-25 11:02:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442373002/1
4 years, 1 month ago (2016-10-25 11:04:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 11:06:01 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:12:18 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d390e11e02dd94d6602c4beb5baf61fd210ca761
Cr-Commit-Position: refs/heads/master@{#40556}

Powered by Google App Engine
This is Rietveld 408576698