chromeos/network/DEPS - Issue 2442313003: Move some proxy config code out of src/chrome

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromeos/network/DEPS

Issue 2442313003: Move some proxy config code out of src/chrome (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+dbus",	2 "+dbus",

3 "+components/onc",	3 "+components/onc",

	4 "+components/policy",

	5 "+components/pref_registry",

4 "+components/proxy_config",	6 "+components/proxy_config",

	7 "+components/user_manager",
	Mattias Nissler (ping if slow) 2016/10/25 09:53:16 Do you really want the user_manager dependency her Do you really want the user_manager dependency here (see also other comments)? stevenjb 2016/10/25 17:26:22 chromeos/ already depends on user_manager in login Show quoted text On 2016/10/25 09:53:16, Mattias Nissler (ping if slow) wrote: > Do you really want the user_manager dependency here (see also other comments)? chromeos/ already depends on user_manager in login/ and cryptohome/, so this doesn't add any real dependencies.
5 "+net",	8 "+net",

6 "+url"	9 "+url"

7 ]	10 ]

OLD	NEW