Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2442223003: Make createElement tag name case handling consistent for custom elements (Closed)

Created:
4 years, 1 month ago by dominicc (has gone to gerrit)
Modified:
4 years, 1 month ago
Reviewers:
kojii
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make createElement tag name case handling consistent for custom elements BUG=649279 Committed: https://crrev.com/be2411a995a513d8bbcb18cbe9c53cb8b664b634 Cr-Commit-Position: refs/heads/master@{#427241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -47 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 3 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp View 3 chunks +3 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementTest.cpp View 2 chunks +28 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h View 2 chunks +79 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.cpp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dominicc (has gone to gerrit)
PTAL
4 years, 1 month ago (2016-10-24 06:21:48 UTC) #4
kojii
lgtm
4 years, 1 month ago (2016-10-24 07:17:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442223003/1
4 years, 1 month ago (2016-10-25 02:10:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 02:15:17 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 02:17:32 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/be2411a995a513d8bbcb18cbe9c53cb8b664b634
Cr-Commit-Position: refs/heads/master@{#427241}

Powered by Google App Engine
This is Rietveld 408576698