Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Issue 2442213003: Remove dead extensions tracking code. (Closed)

Created:
4 years, 1 month ago by Bryan McQuade
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, Devlin
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead extensions tracking code. In https://codereview.chromium.org/2437863005, page_load_histograms, which was the only consumer of this code, was removed. Now that the page_load_histograms code has been removed, this code can be removed as well. BUG=657993 Committed: https://crrev.com/69722fddd0f46c528986bfc87897b0f1607e1f26 Cr-Commit-Position: refs/heads/master@{#429418}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -114 lines) Patch
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api_helpers.h View 1 chunk +0 lines, -11 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api_helpers.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M extensions/browser/runtime_data.h View 2 chunks +0 lines, -7 lines 0 comments Download
M extensions/browser/runtime_data.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M extensions/browser/runtime_data_unittest.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M extensions/common/extension_messages.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/renderer/dispatcher.h View 3 chunks +1 line, -6 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Bryan McQuade
Devlin, PTAL - this change removes extension code that is now dead as a result ...
4 years, 1 month ago (2016-11-02 14:01:36 UTC) #4
Devlin
lgtm
4 years, 1 month ago (2016-11-02 19:07:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442213003/20001
4 years, 1 month ago (2016-11-02 20:45:16 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/295267)
4 years, 1 month ago (2016-11-02 20:55:15 UTC) #11
Bryan McQuade
tsepez, PTAL for extensions/common/extension_messages.h change, thanks!
4 years, 1 month ago (2016-11-02 22:01:07 UTC) #13
Tom Sepez
RS LGTM on deleting messages. Thanks for the cleanup.
4 years, 1 month ago (2016-11-02 22:05:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442213003/20001
4 years, 1 month ago (2016-11-02 22:10:20 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 22:16:06 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 22:20:29 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/69722fddd0f46c528986bfc87897b0f1607e1f26
Cr-Commit-Position: refs/heads/master@{#429418}

Powered by Google App Engine
This is Rietveld 408576698