Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2442203002: Update recipes to understand new Gerrit patch properties. (Closed)

Created:
4 years, 1 month ago by tandrii(chromium)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Update recipes to understand new Gerrit patch properties. Backwards compatible. Depends on https://codereview.chromium.org/2439373002 change to bot_update. BUG=645616 R=machenbach@chromium.org,martiniss@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/build/+/e3c40663ad7cee755da129417d624c0a72962723

Patch Set 1 #

Patch Set 2 : Fix bugs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -29 lines) Patch
M scripts/slave/recipes/boringssl.py View 2 chunks +10 lines, -1 line 0 comments Download
M scripts/slave/recipes/boringssl.expected/gerrit_cl.json View 1 chunk +1 line, -1 line 0 comments Download
A + scripts/slave/recipes/boringssl.expected/gerrit_cl_deprecated.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M scripts/slave/recipes/boringssl_docs.py View 1 1 chunk +8 lines, -0 lines 0 comments Download
M scripts/slave/recipes/boringssl_docs.expected/boringssl-docs-gerrit.json View 1 1 chunk +1 line, -1 line 0 comments Download
A + scripts/slave/recipes/boringssl_docs.expected/boringssl-docs-gerrit-deprecated.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M scripts/slave/recipes/run_presubmit.py View 3 chunks +25 lines, -6 lines 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/depot_tools_and_gerrit.json View 2 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/infra_with_runhooks_and_gerrit.json View 2 chunks +3 lines, -3 lines 0 comments Download
A + scripts/slave/recipes/run_presubmit.expected/infra_with_runhooks_and_gerrit_deprecated.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M scripts/slave/recipes/simple_ci.py View 1 2 chunks +16 lines, -15 lines 0 comments Download
M scripts/slave/recipes/simple_ci.expected/cq_try.json View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
tandrii(chromium)
4 years, 1 month ago (2016-10-24 01:00:07 UTC) #1
Michael Achenbach
lgtm
4 years, 1 month ago (2016-10-24 09:43:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442203002/20001
4 years, 1 month ago (2016-10-26 12:38:09 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 12:47:29 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/e3c40663ad7cee755da1...

Powered by Google App Engine
This is Rietveld 408576698