recipe_modules/properties/example.expected/buildbot_tryserver_gerrit_override_git.json - Issue 2442173003: Add cleaned up Gerrit props to properties.test_api.tryserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_modules/properties/example.expected/buildbot_tryserver_gerrit_override_git.json

Issue 2442173003: Add cleaned up Gerrit props to properties.test_api.tryserver. (Closed)

Patch Set: better diff Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « recipe_modules/properties/example.expected/buildbot_tryserver_gerrit_override_gerrit.json ('k') | recipe_modules/properties/test_api.py » ('j') | recipe_modules/properties/test_api.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: recipe_modules/properties/example.expected/buildbot_tryserver_gerrit_override_git.json

diff --git a/recipe_modules/properties/example.expected/buildbot_generic.json b/recipe_modules/properties/example.expected/buildbot_tryserver_gerrit_override_git.json

similarity index 63%

copy from recipe_modules/properties/example.expected/buildbot_generic.json

copy to recipe_modules/properties/example.expected/buildbot_tryserver_gerrit_override_git.json

index 608b7b0f9affcb29a3392ff6ba833b92631e496d..4fd51695eaf6d35ca7bb1ddf78ac8cca1906b7ad 100644

--- a/recipe_modules/properties/example.expected/buildbot_generic.json

+++ b/recipe_modules/properties/example.expected/buildbot_tryserver_gerrit_override_git.json

@@ -16,6 +16,14 @@

"('buildnumber', 571)",

"('foo.bar-bam', 'thing')",

"('mastername', 'chromium.testing.master')",

+ "('patch_branch', 'master')",

+ "('patch_gerrit_url', 'https://chrome-internal.googlesource.com')",

tandrii(chromium) 2016/10/24 11:23:17 yep, you are right - missing review here.

+ "('patch_issue', 456789)",

+ "('patch_project', 'infra/hidden')",

+ "('patch_ref', 'refs/changes/89/456789/12')",

+ "('patch_repository_url', 'https://chrome-internal.googlesource.com/infra/hidden')",

+ "('patch_set', 12)",

+ "('patch_storage', 'gerrit')",

"('recipe', 'properties:example')",

"('slavename', 'TestSlavename')",

"('test_prop', None)",