Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2442113002: Linux: fix Gtk3 compile when using wheezy sysroot (Closed)

Created:
4 years, 2 months ago by Tom (Use chromium acct)
Modified:
4 years, 2 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux: fix Gtk3 compile when using wheezy sysroot This CL uses a GtkMenu insetad of a GtkHeaderBar to get the frame color. Additionally, we use a 1x1px widget since a menu has a uniform color. In the future, this code must be refactored further, but this is just to fix the build so we can get a trybot config set up. BUG=132847 R=erg@chromium.org Committed: https://crrev.com/1ec85106b90c41fe1f3e0635c7c38cb0db98dbd8 Cr-Commit-Position: refs/heads/master@{#426929}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 3 chunks +10 lines, -15 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
Tom (Use chromium acct)
erg PTAL Besides what we changed earlier, I also made the widget 1x1px. It works ...
4 years, 2 months ago (2016-10-21 21:10:51 UTC) #1
Elliot Glaysher
lgtm
4 years, 2 months ago (2016-10-21 21:22:10 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 2444473002 Patch 1). Please resolve the dependency and ...
4 years, 2 months ago (2016-10-21 21:28:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442113002/1
4 years, 2 months ago (2016-10-21 22:14:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 23:48:03 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 23:52:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ec85106b90c41fe1f3e0635c7c38cb0db98dbd8
Cr-Commit-Position: refs/heads/master@{#426929}

Powered by Google App Engine
This is Rietveld 408576698