Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 2442053002: Enable deprecated SkColorSpace factories named "NewXXX" (Closed)

Created:
4 years, 2 months ago by Brian Osman
Modified:
4 years, 2 months ago
Reviewers:
msarett, mtklein, reed1
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable deprecated SkColorSpace factories named "NewXXX" Factories are being renamed to "MakeXXX" to be consistent with other parts of Skia. See also: https://skia-review.googlesource.com/c/3822/ BUG= Committed: https://crrev.com/b07f20559996aa8154a3a67e742676a9799e37c4 Cr-Commit-Position: refs/heads/master@{#426904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Brian Osman
4 years, 2 months ago (2016-10-21 18:22:11 UTC) #3
reed1
lgtm
4 years, 2 months ago (2016-10-21 18:28:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442053002/1
4 years, 2 months ago (2016-10-21 18:30:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 21:55:10 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 22:00:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b07f20559996aa8154a3a67e742676a9799e37c4
Cr-Commit-Position: refs/heads/master@{#426904}

Powered by Google App Engine
This is Rietveld 408576698