Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2442033002: Update i-beam caret cursor assets (Closed)

Created:
4 years, 2 months ago by Qiang(Joe) Xu
Modified:
4 years, 1 month ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update i-beam caret cursor assets BUG=316738 TEST=tested on device Committed: https://crrev.com/49d945be1c7c69ad0cb79f9ea709ab0f5380106b Cr-Commit-Position: refs/heads/master@{#427162}

Patch Set 1 #

Messages

Total messages: 17 (10 generated)
Qiang(Joe) Xu
Hi oshima@, could you PTAL? Thanks!
4 years, 2 months ago (2016-10-21 17:39:01 UTC) #6
oshima
lgtm can you double check the position hasn't changed? (as the hot point is given ...
4 years, 1 month ago (2016-10-24 18:49:20 UTC) #9
Qiang(Joe) Xu
On 2016/10/24 18:49:20, oshima wrote: > lgtm > > can you double check the position ...
4 years, 1 month ago (2016-10-24 18:59:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442033002/1
4 years, 1 month ago (2016-10-24 20:22:15 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 21:45:17 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/49d945be1c7c69ad0cb79f9ea709ab0f5380106b Cr-Commit-Position: refs/heads/master@{#427162}
4 years, 1 month ago (2016-10-24 21:48:42 UTC) #16
Qiang(Joe) Xu
4 years, 1 month ago (2016-10-25 03:34:12 UTC) #17
Message was sent while issue was closed.
On 2016/10/24 18:49:20, oshima wrote:
> lgtm
> 
> can you double check the position hasn't changed? (as the hot point is given
in
> the cursors_aura.cc)

Checked using GIMP that cursor positions are the same.

Powered by Google App Engine
This is Rietveld 408576698