Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: components/previews/core/previews_experiments.h

Issue 2442013003: Add non-host functionality to the previews blacklist (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/previews/core/previews_experiments.h
diff --git a/components/previews/core/previews_experiments.h b/components/previews/core/previews_experiments.h
index 410e163924b3a59147c9f1eb846d00eb6567b17a..d7065f2a59e0eb14b5cf6ac9615d197220a7609d 100644
--- a/components/previews/core/previews_experiments.h
+++ b/components/previews/core/previews_experiments.h
@@ -6,31 +6,42 @@
#define COMPONENTS_PREVIEWS_CORE_PREVIEWS_EXPERIMENTS_H_
#include "base/time/time.h"
namespace previews {
namespace params {
// The maximum number of recent previews navigations the black list looks at to
// determine if a host is blacklisted.
-size_t MaxStoredHistoryLengthForBlackList();
+size_t MaxStoredHistoryLengthForPerHostBlackList();
+
+// The maximum number of recent previews navigations the black list looks at to
+// determine if all previews navigations are disallowed.
+size_t MaxStoredHistoryLengthForHostIndifferentBlackList();
// The maximum number of hosts allowed in the in memory black list.
size_t MaxInMemoryHostsInBlackList();
// The number of recent navigations that were opted out of that would trigger
tbansal1 2016/10/28 21:59:34 s/opted out of that would trigger the host/opted o
RyanSturm 2016/11/02 19:52:30 Done.
// the host to be blacklisted.
-int BlackListOptOutThreshold();
+int PerHostBlackListOptOutThreshold();
+
+// The number of recent navigations that were opted out of that would trigger
+// the all previews navigations to be disallowed.
+int HostIndifferentBlackListOptOutThreshold();
// The amount of time a host remains blacklisted due to opt outs.
-base::TimeDelta BlackListDuration();
+base::TimeDelta PerHostBlackListDuration();
+
+// The amount of time all previews navigations are disallowed due to opt outs.
+base::TimeDelta HostIndifferentBlackListPerHostDuration();
// The amount of time after any opt out that no previews should be shown.
base::TimeDelta SingleOptOutDuration();
} // namespace params
enum class PreviewsType {
NONE = 0,
OFFLINE = 1,
LAST = 2,

Powered by Google App Engine
This is Rietveld 408576698