Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 2441963002: Update expectations of imported/wpt/service-workers (Closed)

Created:
2 years, 2 months ago by shimazu
Modified:
2 years, 2 months ago
Reviewers:
qyearsley
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update expectations of imported/wpt/service-workers As mentioned at https://crbug.com/602693#c17 and https://crbug.com/657869, '[ Skip ]' in TestExpectations cannot be overwritten by WPTTestExpectations. This patch changes '[ Skip ]' to '[ Failure ]' by default in TestExpectations in order to run the w3c tests on WPTServe bots. BUG=602693, 453190, 624278, 617886, 571722, 618616 TEST=./third_party/WebKit/Tools/Scripts/run-webkit-tests -f -t Debug imported/wpt/service-workers TEST=./third_party/WebKit/Tools/Scripts/run-webkit-tests --enable-wptserve -f -t Debug imported/wpt/service-workers Committed: https://crrev.com/6a97fb88d5ad4c437c60562d0083a87b898547a4 Cr-Commit-Position: refs/heads/master@{#427010}

Patch Set 1 #

Patch Set 2 : Mark some tests "[ Failure Timeout ]" #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -44 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +58 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/WPTServeExpectations View 2 chunks +2 lines, -42 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
shimazu
ptal
2 years, 2 months ago (2016-10-21 04:55:00 UTC) #4
qyearsley
lgtm
2 years, 2 months ago (2016-10-21 16:26:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441963002/20001
2 years, 2 months ago (2016-10-24 01:19:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/92201)
2 years, 2 months ago (2016-10-24 01:22:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441963002/40001
2 years, 2 months ago (2016-10-24 01:52:51 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
2 years, 2 months ago (2016-10-24 02:57:40 UTC) #15
commit-bot: I haz the power
2 years, 2 months ago (2016-10-24 02:59:26 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6a97fb88d5ad4c437c60562d0083a87b898547a4
Cr-Commit-Position: refs/heads/master@{#427010}

Powered by Google App Engine
This is Rietveld 408576698