third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-security-test.html - Issue 2441953002: Shape Detection: Add two layout tests for face detection

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-security-test.html

Issue 2441953002: Shape Detection: Add two layout tests for face detection (Closed)

Patch Set: Use promise_test() instead of async_test() Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp » ('j') | third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src=../../resources/testharness.js></script>

	3 <script src=../../resources/testharnessreport.js></script>

	4 <script>

	5

	6 // TODO(xianglu): Consider adding tests for image with only one dimension

	7 // equal to zero.

	8

	9 // Returns a promise that will resolve to a rejection from detect method.
	mcasas 2016/10/21 23:43:16 This reads a bit confusing, suggest instead: // Re This reads a bit confusing, suggest instead: // Returns a Promise that is resolve()d if detect() fails. In light of that, maybe s/makeTestPromiseWithImageUrl/detectFaceAndExpectError/ or something like that? To avoid having the suffix ..WithImageUrl, just rename the parameter s/url/imageUrl/ and it'll be self explanatory :) xianglu 2016/10/22 02:19:09 Done. Show quoted text On 2016/10/21 23:43:16, mcasas wrote: > This reads a bit confusing, suggest instead: > // Returns a Promise that is resolve()d if detect() fails. > > In light of that, maybe > s/makeTestPromiseWithImageUrl/detectFaceAndExpectError/ > or something like that? > > To avoid having the suffix ..WithImageUrl, just rename > the parameter s/url/imageUrl/ and it'll be self explanatory :) Done.
	10 function makeTestPromiseWithImageUrl(url) {

	11 return new Promise(function(resolve, reject) {

	12 var image = new Image();

	13 var faceDetector = new FaceDetector();

	14 image.onload = makePromise;

	15 image.onerror = makePromise;

	16 function makePromise () {

	17 faceDetector.detect(image)

	18 .then(faceDetectionResult => {

	19 reject("Promise for this test image should have been rejected.");

	20 })

	21 .catch(error => {

	22 resolve(error);

	23 });

	24 };

	25 image.src = url;

	26 });

	27 }

	28

	29 // This test verifies that FaceDetector will reject an empty image.

	30 promise_test(function(t) {

	31 return makeTestPromiseWithImageUrl("")

	32 .then(function(error) {

	33 assert_equals(error.name, "InvalidStateError");

	34 assert_equals(error.message, "HTMLImageElement is empty.");

	35 });

	36 }, "FaceDetector should reject empty images with InvalidStateError.");

	37

	38 // This test verifies that FaceDetector will reject an undecodable image.

	39 promise_test(function(t) {

	40 return makeTestPromiseWithImageUrl("../../imported/wpt/images/broken.png")

	41 .then(function(error) {

	42 assert_equals(error.name, "InvalidStateError");

	43 assert_regexp_match(error.message, /Image is broken*/);

	44 });

	45 }, "FaceDetector should reject undecodable images with InvalidStateError.");

	46

	47 </script>

OLD	NEW