third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp - Issue 2441943002: Retrieve prototype during custom element construction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp

Issue 2441943002: Retrieve prototype during custom element construction. (Closed)

Patch Set: Update after https://codereview.chromium.org/2443543002 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp

index 1d5c406d2cb064e87f5433cf6a1ca91cf24b19d3..73b01d634438d3a3beb7bde55f8edc18a9c8ee11 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp

@@ -154,7 +154,7 @@ bool ScriptCustomElementDefinitionBuilder::rememberOriginalProperties() {

CustomElementDefinition* ScriptCustomElementDefinitionBuilder::build(

const CustomElementDescriptor& descriptor) {

return ScriptCustomElementDefinition::create(

- m_scriptState.get(), m_registry, descriptor, m_constructor, m_prototype,

+ m_scriptState.get(), m_registry, descriptor, m_constructor,

m_connectedCallback, m_disconnectedCallback, m_adoptedCallback,

m_attributeChangedCallback, m_observedAttributes);

}