third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h - Issue 2441943002: Retrieve prototype during custom element construction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

Issue 2441943002: Retrieve prototype during custom element construction. (Closed)

Patch Set: Update after https://codereview.chromium.org/2443543002 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/imported/wpt/custom-elements/htmlconstructor/newtarget-expected.txt ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

index 4619356f9a0409cde370d224a56475631b372245..27eb3dda4c96eb076673054ad34a1b61b6b92945 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

@@ -33,7 +33,6 @@ class CORE_EXPORT ScriptCustomElementDefinition final

CustomElementRegistry*,

const CustomElementDescriptor&,

const v8::Local<v8::Object>& constructor,

- const v8::Local<v8::Object>& prototype,

const v8::Local<v8::Function>& connectedCallback,

const v8::Local<v8::Function>& disconnectedCallback,

const v8::Local<v8::Function>& adoptedCallback,

@@ -43,7 +42,6 @@ class CORE_EXPORT ScriptCustomElementDefinition final

virtual ~ScriptCustomElementDefinition() = default;

v8::Local<v8::Object> constructor() const;

- v8::Local<v8::Object> prototype() const;

HTMLElement* createElementSync(Document&, const QualifiedName&) override;

@@ -66,7 +64,6 @@ class CORE_EXPORT ScriptCustomElementDefinition final

ScriptState*,

const CustomElementDescriptor&,

const v8::Local<v8::Object>& constructor,

- const v8::Local<v8::Object>& prototype,

const v8::Local<v8::Function>& connectedCallback,

const v8::Local<v8::Function>& disconnectedCallback,

const v8::Local<v8::Function>& adoptedCallback,

@@ -90,7 +87,6 @@ class CORE_EXPORT ScriptCustomElementDefinition final

RefPtr<ScriptState> m_scriptState;

ScopedPersistent<v8::Object> m_constructor;

- ScopedPersistent<v8::Object> m_prototype;

ScopedPersistent<v8::Function> m_connectedCallback;

ScopedPersistent<v8::Function> m_disconnectedCallback;

ScopedPersistent<v8::Function> m_adoptedCallback;