[DevTools] Refactor connection-related classes.

third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 60 matching lines @@
     },
 
     dispose: function()
     {
         this._reset();
     },
 
     _reset: function()
     {
         for (var connection of this._connections.values())
-            connection.close();
+            connection._onDisconnect.call(null, "reset");
         this._connections.clear();
         this._targetsByWorkerId.clear();
     },
 
     _onSuspendStateChanged: function()
     {
         var suspended = WebInspector.targetManager.allTargetsSuspended();
         this.target().workerAgent().setWaitForDebuggerOnStart(!suspended);
     },
 
     /**
      * @param {string} workerId
      * @param {string} url
      * @param {boolean} waitingForDebugger
      */
     _workerCreated: function(workerId, url, waitingForDebugger)
     {
-        var connection = new WebInspector.WorkerConnection(this, workerId);
-        this._connections.set(workerId, connection);
-
+        var capabilities = WebInspector.Target.Capability.JS | WebInspector.Target.Capability.Log;
         var parsedURL = url.asParsedURL();
         var workerName = parsedURL ? parsedURL.lastPathComponentWithFragment() : "#" + (++this._lastAnonymousTargetId);
-        var target = WebInspector.targetManager.createTarget(workerName, WebInspector.Target.Capability.JS | WebInspector.Target.Capability.Log, connection, this.target());
+        var target = WebInspector.targetManager.createTarget(workerName, capabilities, this._createConnection.bind(this, workerId), this.target());
         this._targetsByWorkerId.set(workerId, target);
 
         // Only pause new worker if debugging SW - we are going through the
         // pause on start checkbox.
         var mainIsServiceWorker = WebInspector.targetManager.mainTarget().hasWorkerCapability() && !WebInspector.targetManager.mainTarget().hasBrowserCapability();
         if (mainIsServiceWorker && waitingForDebugger)
             target.debuggerAgent().pause();
         target.runtimeAgent().runIfWaitingForDebugger();
     },
 
     /**
      * @param {string} workerId
+     * @param {!InspectorBackendClass.Connection.Params} params
+     * @return {!InspectorBackendClass.Connection}
+     */
+    _createConnection: function(workerId, params)
+    {
+        var connection = new WebInspector.WorkerConnection(this, workerId, params);
+        this._connections.set(workerId, connection);
+        return connection;
+    },
+
+    /**
+     * @param {string} workerId
      */
     _workerTerminated: function(workerId)
     {
         var connection = this._connections.get(workerId);
         if (connection)
-            connection._reportClosed();
+            connection._onDisconnect.call(null, "worker terminated");
         this._connections.delete(workerId);
         this._targetsByWorkerId.delete(workerId);
     },
 
     /**
      * @param {string} workerId
      * @param {string} message
      */
     _dispatchMessageFromWorker: function(workerId, message)
     {
         var connection = this._connections.get(workerId);
         if (connection)
-            connection.dispatch(message);
+            connection._onMessage.call(null, message);
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _mainFrameNavigated: function(event)
     {
         if (event.data.target() !== this.target())
             return;
         this._reset(); // TODO (dgozman): Probably, unnecessary. Consider removal.
@@ skipping 47 matching lines @@
      * @param {string} message
      */
     dispatchMessageFromWorker: function(workerId, message)
     {
         this._workerManager._dispatchMessageFromWorker(workerId, message);
     }
 };
 
 /**
  * @constructor
- * @extends {InspectorBackendClass.Connection}
+ * @implements {InspectorBackendClass.Connection}
  * @param {!WebInspector.WorkerManager} workerManager
  * @param {string} workerId
+ * @param {!InspectorBackendClass.Connection.Params} params
  */
-WebInspector.WorkerConnection = function(workerManager, workerId)
+WebInspector.WorkerConnection = function(workerManager, workerId, params)
 {
-    InspectorBackendClass.Connection.call(this);
-    // FIXME: remove resourceTreeModel and others from worker targets
-    this.suppressErrorsForDomains(["Worker", "Page", "CSS", "DOM", "DOMStorage", "Database", "Network", "IndexedDB"]);
     this._agent = workerManager.target().workerAgent();
     this._workerId = workerId;
+    this._onMessage = params.onMessage;
+    this._onDisconnect = params.onDisconnect;
 };
 
 WebInspector.WorkerConnection.prototype = {
     /**
      * @override
-     * @param {!Object} messageObject
+     * @param {string} message
      */
-    sendMessage: function(messageObject)
+    sendMessage: function(message)
     {
-        this._agent.sendMessageToWorker(this._workerId, JSON.stringify(messageObject));
+        this._agent.sendMessageToWorker(this._workerId, message);
     },
 
-    _reportClosed: function()
+    /**
+     * @override
+     * @return {!Promise}
+     */
+    disconnect: function()
     {
-        this.connectionClosed("worker_terminated");
+        throw new Error("Not implemented");
     },
-
-    __proto__: InspectorBackendClass.Connection.prototype
 };