Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

Issue 2441933002: [DevTools] Refactor connection-related classes. (Closed)
Patch Set: tests.js Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 780 matching lines...) Expand 10 before | Expand all | Expand 10 after
791 return false; 791 return false;
792 var scriptFile = this._debuggerWorkspaceBinding.scriptFile(uiSourceCode, this.target()); 792 var scriptFile = this._debuggerWorkspaceBinding.scriptFile(uiSourceCode, this.target());
793 return !!scriptFile && scriptFile.hasDivergedFromVM(); 793 return !!scriptFile && scriptFile.hasDivergedFromVM();
794 }, 794 },
795 795
796 /** 796 /**
797 * @param {function()} callback 797 * @param {function()} callback
798 */ 798 */
799 _updateInDebugger: function(callback) 799 _updateInDebugger: function(callback)
800 { 800 {
801 if (this.target().isDetached()) { 801 if (this.target().isDisposed()) {
802 this._cleanUpAfterDebuggerIsGone(); 802 this._cleanUpAfterDebuggerIsGone();
803 callback(); 803 callback();
804 return; 804 return;
805 } 805 }
806 806
807 var uiSourceCode = this._breakpoint.uiSourceCode(); 807 var uiSourceCode = this._breakpoint.uiSourceCode();
808 var lineNumber = this._breakpoint._lineNumber; 808 var lineNumber = this._breakpoint._lineNumber;
809 var columnNumber = this._breakpoint._columnNumber; 809 var columnNumber = this._breakpoint._columnNumber;
810 var condition = this._breakpoint.condition(); 810 var condition = this._breakpoint.condition();
811 811
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
1075 { 1075 {
1076 this.sourceFileId = breakpoint._sourceFileId; 1076 this.sourceFileId = breakpoint._sourceFileId;
1077 this.lineNumber = breakpoint.lineNumber(); 1077 this.lineNumber = breakpoint.lineNumber();
1078 this.columnNumber = breakpoint.columnNumber(); 1078 this.columnNumber = breakpoint.columnNumber();
1079 this.condition = breakpoint.condition(); 1079 this.condition = breakpoint.condition();
1080 this.enabled = breakpoint.enabled(); 1080 this.enabled = breakpoint.enabled();
1081 }; 1081 };
1082 1082
1083 /** @type {!WebInspector.BreakpointManager} */ 1083 /** @type {!WebInspector.BreakpointManager} */
1084 WebInspector.breakpointManager; 1084 WebInspector.breakpointManager;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698