Fix <webview> subframe resource loads with PlzNavigate.

chrome/browser/extensions/extension_protocols_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
 
 #include "base/files/file_util.h"
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/values.h"
 #include "chrome/common/chrome_paths.h"
 #include "content/public/browser/resource_request_info.h"
+#include "content/public/common/browser_side_navigation_policy.h"
 #include "content/public/test/mock_resource_context.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "extensions/browser/extension_protocols.h"
 #include "extensions/browser/info_map.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/file_util.h"
 #include "net/base/request_priority.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_job_factory_impl.h"
@@ skipping 194 matching lines @@
         EXPECT_EQ(net::ERR_FILE_NOT_FOUND, test_delegate_.request_status())
             << cases[i].name;
       } else {
         EXPECT_EQ(net::ERR_BLOCKED_BY_CLIENT, test_delegate_.request_status())
             << cases[i].name;
       }
     }
 
     // Now do a subframe request.
     {
-      std::unique_ptr<net::URLRequest> request(
-          resource_context_.GetRequestContext()->CreateRequest(
-              extension->GetResourceURL("404.html"), net::DEFAULT_PRIORITY,
-              &test_delegate_));
-      StartRequest(request.get(), content::RESOURCE_TYPE_SUB_FRAME);
+      // With PlzNavigate, the subframe navigation requests are blocked in
+      // ExtensionNavigationThrottle which isn't added in this unit test. This
+      // is tested in an integration test in
+      // ExtensionResourceRequestPolicyTest.IframeNavigateToInaccessible.
+      if (!content::IsBrowserSideNavigationEnabled()) {
+        std::unique_ptr<net::URLRequest> request(
+            resource_context_.GetRequestContext()->CreateRequest(
+                extension->GetResourceURL("404.html"), net::DEFAULT_PRIORITY,
+                &test_delegate_));
+        StartRequest(request.get(), content::RESOURCE_TYPE_SUB_FRAME);
 
-      if (cases[i].should_allow_sub_frame_load) {
-        EXPECT_EQ(net::ERR_FILE_NOT_FOUND, test_delegate_.request_status())
-            << cases[i].name;
-      } else {
-        EXPECT_EQ(net::ERR_BLOCKED_BY_CLIENT, test_delegate_.request_status())
-            << cases[i].name;
+        if (cases[i].should_allow_sub_frame_load) {
+          EXPECT_EQ(net::ERR_FILE_NOT_FOUND, test_delegate_.request_status())
+              << cases[i].name;
+        } else {
+          EXPECT_EQ(net::ERR_BLOCKED_BY_CLIENT, test_delegate_.request_status())
+              << cases[i].name;
+        }
       }
     }
   }
 }
 
 void CheckForContentLengthHeader(net::URLRequest* request) {
   std::string content_length;
   request->GetResponseHeaderByName(net::HttpRequestHeaders::kContentLength,
                                   &content_length);
   EXPECT_FALSE(content_length.empty());
@@ skipping 94 matching lines @@
   // should not succeed.
   {
     std::unique_ptr<net::URLRequest> request(
         resource_context_.GetRequestContext()->CreateRequest(
             extension->GetResourceURL("test.dat"), net::DEFAULT_PRIORITY,
             &test_delegate_));
     StartRequest(request.get(), content::RESOURCE_TYPE_MAIN_FRAME);
     EXPECT_EQ(net::OK, test_delegate_.request_status());
   }
   {
-    std::unique_ptr<net::URLRequest> request(
-        resource_context_.GetRequestContext()->CreateRequest(
-            extension->GetResourceURL("test.dat"), net::DEFAULT_PRIORITY,
-            &test_delegate_));
-    StartRequest(request.get(), content::RESOURCE_TYPE_SUB_FRAME);
-    EXPECT_EQ(net::ERR_BLOCKED_BY_CLIENT, test_delegate_.request_status());
+    // With PlzNavigate, the subframe navigation requests are blocked in
+    // ExtensionNavigationThrottle which isn't added in this unit test. This is
+    // tested in an integration test in
+    // ExtensionResourceRequestPolicyTest.IframeNavigateToInaccessible.
+    if (!content::IsBrowserSideNavigationEnabled()) {
+      std::unique_ptr<net::URLRequest> request(
+          resource_context_.GetRequestContext()->CreateRequest(
+              extension->GetResourceURL("test.dat"), net::DEFAULT_PRIORITY,
+              &test_delegate_));
+      StartRequest(request.get(), content::RESOURCE_TYPE_SUB_FRAME);
+      EXPECT_EQ(net::ERR_BLOCKED_BY_CLIENT, test_delegate_.request_status());
+    }
   }
 
   // And subresource types, such as media, should fail.
   {
     std::unique_ptr<net::URLRequest> request(
         resource_context_.GetRequestContext()->CreateRequest(
             extension->GetResourceURL("test.dat"), net::DEFAULT_PRIORITY,
             &test_delegate_));
     StartRequest(request.get(), content::RESOURCE_TYPE_MEDIA);
     EXPECT_EQ(net::ERR_BLOCKED_BY_CLIENT, test_delegate_.request_status());
@@ skipping 22 matching lines @@
             DoRequest(*extension, relative_path.AsUTF8Unsafe()));
 
   // Loading "/_metadata/a.txt" should also fail.
   relative_path = base::FilePath(kMetadataFolder).AppendASCII("a.txt");
   EXPECT_TRUE(base::PathExists(extension_dir.Append(relative_path)));
   EXPECT_EQ(net::ERR_FAILED,
             DoRequest(*extension, relative_path.AsUTF8Unsafe()));
 }
 
 }  // namespace extensions