Re-expand payments UI after cancelling out of a payment app.

Re-expand payments UI after cancelling out of a payment app.

If the user launches a payment app from expanded payments UI and cancels
the payment in the app, then the payments UI should again be expanded.

BUG=658222
Committed: https://crrev.com/dcdd172565099e4562750373a4ace19e43936949
Cr-Commit-Position: refs/heads/master@{#427135}

[please use gerrit instead, 2016-10-21 12:57:44]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 12:57:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-10-21 12:58:28]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[please use gerrit instead, 2016-10-21 12:58:29]

dfalcantara, ptal.

[commit-bot: I haz the power, 2016-10-21 13:39:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 13:39:20]

Dry run: This issue passed the CQ dry run.

[gone, 2016-10-24 18:03:19]

https://codereview.chromium.org/2441833003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
(left):

https://codereview.chromium.org/2441833003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:836:
params.gravity = Gravity.CENTER_HORIZONTAL | Gravity.BOTTOM;
Were the width and gravity params not required anymore?  They might have been
required because this thing flipped between being a bottom sheet and floaty
dialog, but I don't know what the current state of the world is.

[please use gerrit instead, 2016-10-24 18:59:11]

https://codereview.chromium.org/2441833003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
(left):

https://codereview.chromium.org/2441833003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:836:
params.gravity = Gravity.CENTER_HORIZONTAL | Gravity.BOTTOM;
On 2016/10/24 18:03:19, dfalcantara (slow 10.24) wrote:
> Were the width and gravity params not required anymore?  They might have been
> required because this thing flipped between being a bottom sheet and floaty
> dialog, but I don't know what the current state of the world is.

The width and gravity are always MATCH_PARENT and CENTER_HORIZONTAL|BOTTOM. See
line 385.

[gone, 2016-10-24 19:02:00]

So, yep, the state of the world changed.

lgtm

[please use gerrit instead, 2016-10-24 19:04:40]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2016-10-24 19:05:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 20:27:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-24 20:29:08]

Description was changed from

==========
Re-expand payments UI after cancelling out of a payment app.

If the user launches a payment app from expanded payments UI and cancels
the payment in the app, then the payments UI should again be expanded.

BUG=658222
==========

to

==========
Re-expand payments UI after cancelling out of a payment app.

If the user launches a payment app from expanded payments UI and cancels
the payment in the app, then the payments UI should again be expanded.

BUG=658222

Committed: https://crrev.com/dcdd172565099e4562750373a4ace19e43936949
Cr-Commit-Position: refs/heads/master@{#427135}
==========

[commit-bot: I haz the power, 2016-10-24 20:29:09]

Patchset 1 (id:??) landed as
https://crrev.com/dcdd172565099e4562750373a4ace19e43936949
Cr-Commit-Position: refs/heads/master@{#427135}