Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2441803002: DO NOT COMMIT: Revert "Enable subframe FrameNavigationEntries by default." (Closed)

Created:
4 years, 2 months ago by Charlie Reis
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, jam, darin-cc_chromium.org, android-webview-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DO NOT COMMIT: Revert "Enable subframe FrameNavigationEntries by default." This reverts commit 111baab648276f64b58d7af5b3f47fd3823dc42e. This also disables --isolate-extensions, to test the old path on M56. BUG= [Closed. Had failures due to r425171 and others. Landed r426880 instead.]

Patch Set 1 #

Patch Set 2 : Fix bug in UpdateState. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_process_policy.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 1 chunk +3 lines, -6 lines 0 comments Download
M content/common/site_isolation_policy.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (9 generated)
Charlie Reis
The CQ bit was checked by creis@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-20 20:38:45 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441803002/1
4 years, 2 months ago (2016-10-20 20:39:24 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-20 21:29:10 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/316366)
4 years, 2 months ago (2016-10-20 21:29:11 UTC) #4
Charlie Reis
The CQ bit was checked by creis@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-21 17:17:19 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441803002/20001
4 years, 2 months ago (2016-10-21 17:17:53 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-21 18:15:26 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/302947)
4 years, 2 months ago (2016-10-21 18:15:27 UTC) #8
Charlie Reis
4 years, 2 months ago (2016-10-21 21:13:36 UTC) #9 
Description was changed from

==========
DO NOT COMMIT: Revert "Enable subframe FrameNavigationEntries by default."

This reverts commit 111baab648276f64b58d7af5b3f47fd3823dc42e.
This also disables --isolate-extensions, to test the old path on M56.

BUG=
==========

to

==========
DO NOT COMMIT: Revert "Enable subframe FrameNavigationEntries by default."

This reverts commit 111baab648276f64b58d7af5b3f47fd3823dc42e.
This also disables --isolate-extensions, to test the old path on M56.

BUG=

[Closed. Had failures due to r425171 and others. Landed r426880 instead.]
==========

Powered by Google App Engine
This is Rietveld 408576698