Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: testing/test.gni

Issue 2441793002: Use "Organization Identifier" as prefix for gtest CFBundleIdentifier. (Closed)
Patch Set: Fix ios_chrome_unittests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: testing/test.gni
diff --git a/testing/test.gni b/testing/test.gni
index 86b4abf45c62bff7b327b1f62ff205633d39df1b..e8f9dcbf0dfcfe0892af64d9aa013b31b9a839de 100644
--- a/testing/test.gni
+++ b/testing/test.gni
@@ -249,10 +249,16 @@ template("test") {
info_plist = "//testing/gtest_ios/unittest-Info.plist"
}
+ _bundle_id_suffix = target_name
+ if (ios_automatically_manage_certs) {
+ # Use the same bundle identifier for all unit tests when managing
+ # certificates automatically as the number of free certs is limited.
+ _bundle_id_suffix = "generic-unit-test"
+ }
if (!defined(extra_substitutions)) {
extra_substitutions = []
}
- extra_substitutions += [ "BUNDLE_ID_TEST_NAME=$target_name" ]
+ extra_substitutions += [ "GTEST_BUNDLE_ID_SUFFIX=$_bundle_id_suffix" ]
if (!defined(deps)) {
deps = []
« testing/gtest_ios/unittest-Info.plist ('K') | « testing/gtest_ios/unittest-Info.plist ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698