Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: testing/gtest_ios/unittest-Info.plist

Issue 2441793002: Use "Organization Identifier" as prefix for gtest CFBundleIdentifier. (Closed)
Patch Set: Fix ios_chrome_unittests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/ios/rules.gni ('k') | testing/test.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/gtest_ios/unittest-Info.plist
diff --git a/testing/gtest_ios/unittest-Info.plist b/testing/gtest_ios/unittest-Info.plist
index dc34aa0013c7dbbda71c3786b3de8f1c15d5b3f3..9828f1161231a5d6b8413845163416da60d96738 100644
--- a/testing/gtest_ios/unittest-Info.plist
+++ b/testing/gtest_ios/unittest-Info.plist
@@ -9,7 +9,7 @@
<key>CFBundleExecutable</key>
<string>${EXECUTABLE_NAME}</string>
<key>CFBundleIdentifier</key>
- <string>com.google.gtest.${BUNDLE_ID_TEST_NAME:rfc1034identifier}</string>
+ <string>${IOS_BUNDLE_ID_PREFIX}.gtest.${GTEST_BUNDLE_ID_SUFFIX:rfc1034identifier}</string>
<key>CFBundleInfoDictionaryVersion</key>
<string>6.0</string>
<key>CFBundleName</key>
@@ -151,10 +151,10 @@
<dict>
<key>CFBundleURLSchemes</key>
<array>
- <string>${BUNDLE_ID_TEST_NAME:rfc1034identifier}.http</string>
- <string>${BUNDLE_ID_TEST_NAME:rfc1034identifier}.https</string>
- <string>${BUNDLE_ID_TEST_NAME:rfc1034identifier}-x-callback</string>
- <string>com.google.sso.${BUNDLE_ID_TEST_NAME:rfc1034identifier}</string>
+ <string>${PRODUCT_NAME:rfc1034identifier}.http</string>
+ <string>${PRODUCT_NAME:rfc1034identifier}.https</string>
+ <string>${PRODUCT_NAME:rfc1034identifier}-x-callback</string>
+ <string>${IOS_BUNDLE_ID_PREFIX}.sso.${PRODUCT_NAME:rfc1034identifier}</string>
justincohen 2016/10/21 19:53:33 I'm not sure how this will work with different pre
sdefresne 2016/10/24 12:29:23 I you need to have entitlement for org.chromium.ss
</array>
</dict>
</array>
@@ -187,6 +187,6 @@
<string>fetch</string>
</array>
<key>SSOAuthURLScheme</key>
- <string>com.google.sso.${BUNDLE_ID_TEST_NAME:rfc1034identifier}</string>
+ <string>${IOS_BUNDLE_ID_PREFIX}.sso.${PRODUCT_NAME:rfc1034identifier}</string>
justincohen 2016/10/21 19:53:33 ditto
</dict>
</plist>
« no previous file with comments | « build/config/ios/rules.gni ('k') | testing/test.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698