Use "Organization Identifier" as prefix for gtest CFBundleIdentifier.

Use "Organization Identifier" as prefix for gtest CFBundleIdentifier.

Respect the ios_app_bundle_id_prefix and ios_automatically_manage_certs
when generating the Info.plist file for unit tests targets on iOS.

BUG=613543
Committed: https://crrev.com/ae44722d0182c5a6aa6e71aa0ed4a53e2cf64341
Cr-Commit-Position: refs/heads/master@{#427057}

[sdefresne, 2016-10-20 20:25:11]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 20:25:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-10-20 20:26:23]

sdefresne@chromium.org changed reviewers:
+ dpranke@chromium.org, justincohen@google.com

[sdefresne, 2016-10-20 20:26:23]

sdefresne@chromium.org changed required reviewers:
+ dpranke@chromium.org, justincohen@google.com

[sdefresne, 2016-10-20 20:26:24]

Justin, can you review that this respect what we discussed and will work with
the support for free certs?

Dirk, can you review as OWNERS?

[commit-bot: I haz the power, 2016-10-20 20:51:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 20:51:16]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sdefresne, 2016-10-20 22:04:39]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 22:05:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 23:33:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 23:33:11]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-10-21 03:17:20]

lgtm

[justincohen, 2016-10-21 19:52:40]

justincohen@chromium.org changed reviewers:
+ justincohen@chromium.org

[justincohen, 2016-10-21 19:52:40]

I'm not certain how to test the SSO line, but the rest works.

I set:
  ios_app_bundle_id_prefix = "com.justincohen.chromium"
  ios_automatically_manage_certs = true

And used my sample Xcode project that automatically generates certs with a
project with a bundle id of 'com.justincohen.chromium.gtest.generic-unit-test'
and I was able to deploy the built product.

LGTM

[justincohen, 2016-10-21 19:53:34]

https://codereview.chromium.org/2441793002/diff/20001/testing/gtest_ios/unitt...
File testing/gtest_ios/unittest-Info.plist (right):

https://codereview.chromium.org/2441793002/diff/20001/testing/gtest_ios/unitt...
testing/gtest_ios/unittest-Info.plist:157:
<string>${IOS_BUNDLE_ID_PREFIX}.sso.${PRODUCT_NAME:rfc1034identifier}</string>
I'm not sure how this will work with different prefixes... but this change still
LGTM

https://codereview.chromium.org/2441793002/diff/20001/testing/gtest_ios/unitt...
testing/gtest_ios/unittest-Info.plist:190:
<string>${IOS_BUNDLE_ID_PREFIX}.sso.${PRODUCT_NAME:rfc1034identifier}</string>
ditto

[sdefresne, 2016-10-24 12:29:23]

https://codereview.chromium.org/2441793002/diff/20001/testing/gtest_ios/unitt...
File testing/gtest_ios/unittest-Info.plist (right):

https://codereview.chromium.org/2441793002/diff/20001/testing/gtest_ios/unitt...
testing/gtest_ios/unittest-Info.plist:157:
<string>${IOS_BUNDLE_ID_PREFIX}.sso.${PRODUCT_NAME:rfc1034identifier}</string>
On 2016/10/21 19:53:33, justincohen wrote:
> I'm not sure how this will work with different prefixes... but this change
still
> LGTM

I you need to have entitlement for org.chromium.sso.ios-chrome-unittests in
keychain-access-groups, something like this:

	<key>keychain-access-groups</key>
	<array>
		<string>$(AppIdentifierPrefix)$(CFBundleIdentifier)</string>
		<string>$(AppIdentifierPrefix)org.chromium.sso.ios-chrome-unittests</string>
	</array>

in the entitlements file and a mobile provisioning with the same entitlements
IIRC.

[sdefresne, 2016-10-24 12:29:45]

Description was changed from

==========
Use "Organization Identifier" as prefix for gtest CFBundleIdentifier.

Respect the ios_app_bundle_id_prefix and ios_automatically_manage_certs
when generating the Info.plist file for unit tests targets on iOS.

BUG=613543
==========

to

==========
Use "Organization Identifier" as prefix for gtest CFBundleIdentifier.

Respect the ios_app_bundle_id_prefix and ios_automatically_manage_certs
when generating the Info.plist file for unit tests targets on iOS.

BUG=613543
==========

[sdefresne, 2016-10-24 12:29:45]

sdefresne@chromium.org changed reviewers:
- justincohen@google.com

[sdefresne, 2016-10-24 12:29:45]

sdefresne@chromium.org changed required reviewers:
+ justincohen@chromium.org
- justincohen@google.com

[sdefresne, 2016-10-24 12:29:49]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-10-24 12:30:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 13:35:02]

Description was changed from

==========
Use "Organization Identifier" as prefix for gtest CFBundleIdentifier.

Respect the ios_app_bundle_id_prefix and ios_automatically_manage_certs
when generating the Info.plist file for unit tests targets on iOS.

BUG=613543
==========

to

==========
Use "Organization Identifier" as prefix for gtest CFBundleIdentifier.

Respect the ios_app_bundle_id_prefix and ios_automatically_manage_certs
when generating the Info.plist file for unit tests targets on iOS.

BUG=613543
==========

[commit-bot: I haz the power, 2016-10-24 13:35:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-24 13:37:28]

Description was changed from

==========
Use "Organization Identifier" as prefix for gtest CFBundleIdentifier.

Respect the ios_app_bundle_id_prefix and ios_automatically_manage_certs
when generating the Info.plist file for unit tests targets on iOS.

BUG=613543
==========

to

==========
Use "Organization Identifier" as prefix for gtest CFBundleIdentifier.

Respect the ios_app_bundle_id_prefix and ios_automatically_manage_certs
when generating the Info.plist file for unit tests targets on iOS.

BUG=613543

Committed: https://crrev.com/ae44722d0182c5a6aa6e71aa0ed4a53e2cf64341
Cr-Commit-Position: refs/heads/master@{#427057}
==========

[commit-bot: I haz the power, 2016-10-24 13:37:29]

Patchset 2 (id:??) landed as
https://crrev.com/ae44722d0182c5a6aa6e71aa0ed4a53e2cf64341
Cr-Commit-Position: refs/heads/master@{#427057}