Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2441763003: formalize host debugging (Closed)

Created:
4 years, 2 months ago by caryclark
Modified:
4 years, 1 month ago
Reviewers:
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

formalize host debugging Pathops writes files, anticipating upcoming crashes, and verifies the results against regions. Formalize these debugging methods so that they are more easily triggered by hosts outside of skia unit tests. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2441763003 Committed: https://skia.googlesource.com/skia/+/1326068147ee60de138061a3fc1157fcfd5d017b

Patch Set 1 #

Patch Set 2 : wip; refactor old code #

Patch Set 3 : wip; test #

Patch Set 4 : refactor command flags #

Patch Set 5 : continue running after error #

Patch Set 6 : move remaining debugging code #

Patch Set 7 : clean up mistakes #

Patch Set 8 : merge with ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -186 lines) Patch
M src/pathops/SkPathOpsDebug.h View 1 2 3 4 5 1 chunk +21 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 1 2 3 4 5 6 chunks +215 lines, -16 lines 0 comments Download
M src/pathops/SkPathOpsOp.cpp View 1 2 3 4 5 3 chunks +12 lines, -154 lines 0 comments Download
M src/pathops/SkPathOpsSimplify.cpp View 1 2 3 4 5 2 chunks +15 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsTypes.h View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M tests/PathOpsBuilderConicTest.cpp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M tests/PathOpsDebug.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M tests/PathOpsExtendedTest.h View 1 2 3 4 5 6 1 chunk +0 lines, -4 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M tests/PathOpsFuzz763Test.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsIssue3651.cpp View 1 2 3 4 5 6 2 chunks +4 lines, -2 lines 0 comments Download
M tests/PathOpsQuadIntersectionTest.cpp View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M tests/skia_test.cpp View 1 2 3 4 5 6 3 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (18 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441763003/140001
4 years, 1 month ago (2016-10-24 12:09:18 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 12:10:17 UTC) #20
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/1326068147ee60de138061a3fc1157fcfd5d017b

Powered by Google App Engine
This is Rietveld 408576698