Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2441743002: Fix two io tests for precompilation, update status (Closed)

Created:
4 years, 2 months ago by Florian Schneider
Modified:
4 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix two io tests for precompilation, update status BUG=#26376 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/c3fb2b5d898eb65399d7f041d4db9ebaed63d4ae

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -6 lines) Patch
M tests/standalone/io/pipe_server_test.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M tests/standalone/io/stream_pipe_test.dart View 5 chunks +6 lines, -4 lines 0 comments Download
M tests/standalone/standalone.status View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Florian Schneider
This should make the bots green. Need to investigate why the secure socket tests fail ...
4 years, 2 months ago (2016-10-20 18:52:23 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/2441743002/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/2441743002/diff/1/tests/standalone/standalone.status#newcode335 tests/standalone/standalone.status:335: io/http_server_response_test: Crash For this one, https://chromiumcodereview.appspot.com/2432923005/
4 years, 2 months ago (2016-10-20 19:14:18 UTC) #3
Florian Schneider
https://codereview.chromium.org/2441743002/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/2441743002/diff/1/tests/standalone/standalone.status#newcode335 tests/standalone/standalone.status:335: io/http_server_response_test: Crash On 2016/10/20 19:14:18, rmacnak wrote: > For ...
4 years, 2 months ago (2016-10-20 20:11:59 UTC) #4
Florian Schneider
4 years, 2 months ago (2016-10-20 20:14:18 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
c3fb2b5d898eb65399d7f041d4db9ebaed63d4ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698