Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2441713002: Remove some thread-unsafe statics in (Closed)

Created:
4 years, 2 months ago by eroman
Modified:
4 years, 2 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some thread-unsafe statics in CertVerifyProc::HasTooLongValidity(). BUG=657903 Committed: https://crrev.com/241b859db909a92795cf74a34ea1aa313f8ce64d Cr-Commit-Position: refs/heads/master@{#426616}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove INT64_C() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M net/cert/cert_verify_proc.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
eroman
4 years, 2 months ago (2016-10-20 17:43:37 UTC) #4
Ryan Sleevi
LGTM % nit https://codereview.chromium.org/2441713002/diff/1/net/cert/cert_verify_proc.cc File net/cert/cert_verify_proc.cc (right): https://codereview.chromium.org/2441713002/diff/1/net/cert/cert_verify_proc.cc#newcode697 net/cert/cert_verify_proc.cc:697: base::Time::FromInternalValue(INT64_C(12985574400000000)); This is no longer necessary ...
4 years, 2 months ago (2016-10-20 20:24:56 UTC) #7
eroman
https://codereview.chromium.org/2441713002/diff/1/net/cert/cert_verify_proc.cc File net/cert/cert_verify_proc.cc (right): https://codereview.chromium.org/2441713002/diff/1/net/cert/cert_verify_proc.cc#newcode697 net/cert/cert_verify_proc.cc:697: base::Time::FromInternalValue(INT64_C(12985574400000000)); On 2016/10/20 20:24:56, Ryan Sleevi (at conf til ...
4 years, 2 months ago (2016-10-20 21:06:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441713002/20001
4 years, 2 months ago (2016-10-20 22:02:43 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 22:15:32 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:23:26 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/241b859db909a92795cf74a34ea1aa313f8ce64d
Cr-Commit-Position: refs/heads/master@{#426616}

Powered by Google App Engine
This is Rietveld 408576698