|
|
Created:
4 years, 2 months ago by eroman Modified:
4 years, 2 months ago Reviewers:
Ryan Sleevi CC:
chromium-reviews, cbentzel+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove some thread-unsafe statics in
CertVerifyProc::HasTooLongValidity().
BUG=657903
Committed: https://crrev.com/241b859db909a92795cf74a34ea1aa313f8ce64d
Cr-Commit-Position: refs/heads/master@{#426616}
Patch Set 1 #
Total comments: 2
Patch Set 2 : remove INT64_C() #Messages
Total messages: 19 (13 generated)
The CQ bit was checked by eroman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
eroman@chromium.org changed reviewers: + rsleevi@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM % nit https://codereview.chromium.org/2441713002/diff/1/net/cert/cert_verify_proc.cc File net/cert/cert_verify_proc.cc (right): https://codereview.chromium.org/2441713002/diff/1/net/cert/cert_verify_proc.c... net/cert/cert_verify_proc.cc:697: base::Time::FromInternalValue(INT64_C(12985574400000000)); This is no longer necessary for C++11 - as promotion now includes both long and long long.
The CQ bit was checked by eroman@chromium.org to run a CQ dry run
The CQ bit was checked by eroman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2441713002/diff/1/net/cert/cert_verify_proc.cc File net/cert/cert_verify_proc.cc (right): https://codereview.chromium.org/2441713002/diff/1/net/cert/cert_verify_proc.c... net/cert/cert_verify_proc.cc:697: base::Time::FromInternalValue(INT64_C(12985574400000000)); On 2016/10/20 20:24:56, Ryan Sleevi (at conf til 10-21 wrote: > This is no longer necessary for C++11 - as promotion now includes both long and > long long. Done -- Did not know that, thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by eroman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org Link to the patchset: https://codereview.chromium.org/2441713002/#ps20001 (title: "remove INT64_C()")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove some thread-unsafe statics in CertVerifyProc::HasTooLongValidity(). BUG=657903 ========== to ========== Remove some thread-unsafe statics in CertVerifyProc::HasTooLongValidity(). BUG=657903 Committed: https://crrev.com/241b859db909a92795cf74a34ea1aa313f8ce64d Cr-Commit-Position: refs/heads/master@{#426616} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/241b859db909a92795cf74a34ea1aa313f8ce64d Cr-Commit-Position: refs/heads/master@{#426616} |