Make editingIgnoresContents() as global function

third_party/WebKit/Source/core/editing/EditingStrategy.cpp

Index: third_party/WebKit/Source/core/editing/EditingStrategy.cpp
diff --git a/third_party/WebKit/Source/core/editing/EditingStrategy.cpp b/third_party/WebKit/Source/core/editing/EditingStrategy.cpp
index 57a85f24bbf7a3f924bcdd38510a8d6f797bd59f..0c311fecf17033ecc2720629d38af69c5c434699 100644
--- a/third_party/WebKit/Source/core/editing/EditingStrategy.cpp
+++ b/third_party/WebKit/Source/core/editing/EditingStrategy.cpp
@@ -23,9 +23,11 @@ int EditingAlgorithm<Traversal>::caretMaxOffset(const Node& node) {
   return lastOffsetForEditing(&node);
 }
 
-template <typename Traversal>
-bool EditingAlgorithm<Traversal>::isEmptyNonEditableNodeInEditable(
-    const Node* node) {
+// TODO(yosin): We should move "isEmptyNonEditableNodeInEditable()" to
+// "EditingUtilities.cpp"
+// |isEmptyNonEditableNodeInEditable()| is introduced for fixing
+// http://crbug.com/428986.
+static bool isEmptyNonEditableNodeInEditable(const Node* node) {
   // Editability is defined the DOM tree rather than the flat tree. For example:
   // DOM:
   //   <host>
@@ -36,12 +38,16 @@ bool EditingAlgorithm<Traversal>::isEmptyNonEditableNodeInEditable(
   // Flat Tree:
   //   <host><div ce><span1>unedittable</span></div></host>
   // e.g. editing/shadow/breaking-editing-boundaries.html
-  return !Traversal::hasChildren(*node) && !hasEditableStyle(*node) &&
+  return !NodeTraversal::hasChildren(*node) && !hasEditableStyle(*node) &&

[Xiaocheng, 2016/10/21 10:52:25]

Nice observation.

[yosin_UTC9, 2016/10/24 03:32:36]

(^_^)

          node->parentNode() && hasEditableStyle(*node->parentNode());
 }
 
-template <typename Traversal>
-bool EditingAlgorithm<Traversal>::editingIgnoresContent(const Node* node) {
+// TODO(yosin): We should move "editingIgnoresContent()" to
+// "EditingUtilities.cpp"
+// TODO(yosin): We should not use |isEmptyNonEditableNodeInEditable()| in
+// |editingIgnoresContent()| since |isEmptyNonEditableNodeInEditable()|
+// requires clean layout tree.
+bool editingIgnoresContent(const Node* node) {
   return !node->canContainRangeEndPoint() ||
          isEmptyNonEditableNodeInEditable(node);
 }