Make editingIgnoresContents() as global function

Make editingIgnoresContents() as global function

This patch makes |editingIgnoresContents()| as global function instead of
static member function of template class |EditingStratgegy| since it doesn't
use template parameter to simplify code for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Committed: https://crrev.com/d843d2ba859914b09e483c53be80b0150fda0937
Cr-Commit-Position: refs/heads/master@{#427016}

[yosin_UTC9, 2016-10-21 02:33:07]

Description was changed from

==========
2016-10-21T11:31:46

BUG=
==========

to

==========
Make editingIgnoresContents() as global function


BUG=
==========

[yosin_UTC9, 2016-10-21 02:33:18]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 02:33:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 03:57:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 03:57:21]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-10-21 04:08:32]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 04:08:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 04:26:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 04:26:05]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[yosin_UTC9, 2016-10-21 06:27:23]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 06:27:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 08:11:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 08:11:42]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-10-21 08:19:39]

Description was changed from

==========
Make editingIgnoresContents() as global function


BUG=
==========

to

==========
Make editingIgnoresContents() as global function

This patch makes |editingIgnoresContents()| as global function instead of
static member function of template class |EditingStratgegy| since it doesn't
use template parameter to simplify code for improving code health.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-10-21 08:19:51]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-10-21 08:19:51]

PTAL

[Xiaocheng, 2016-10-21 10:52:26]

lgtm

https://codereview.chromium.org/2441693004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/EditingStrategy.cpp (right):

https://codereview.chromium.org/2441693004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/EditingStrategy.cpp:41: return
!NodeTraversal::hasChildren(*node) && !hasEditableStyle(*node) &&
Nice observation.

https://codereview.chromium.org/2441693004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/EditingStrategy.h (left):

https://codereview.chromium.org/2441693004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/EditingStrategy.h:28: // TODO(yosin) We
should make following functions to take |Node&| instead
Nit: we should keep this TODO in EditingStrategy.cpp.

[yosin_UTC9, 2016-10-24 03:31:38]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-10-24 03:31:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2441693004/#ps60001
(title: "2016-10-24T12:29:25")

[commit-bot: I haz the power, 2016-10-24 03:31:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-10-24 03:32:36]

Thanks for reviewing!
Add TODO comment.
Committing...

https://codereview.chromium.org/2441693004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/EditingStrategy.cpp (right):

https://codereview.chromium.org/2441693004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/EditingStrategy.cpp:41: return
!NodeTraversal::hasChildren(*node) && !hasEditableStyle(*node) &&
On 2016/10/21 at 10:52:25, Xiaocheng wrote:
> Nice observation.

(^_^)

https://codereview.chromium.org/2441693004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/EditingStrategy.h (left):

https://codereview.chromium.org/2441693004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/EditingStrategy.h:28: // TODO(yosin) We
should make following functions to take |Node&| instead
On 2016/10/21 at 10:52:25, Xiaocheng wrote:
> Nit: we should keep this TODO in EditingStrategy.cpp.

Done.

[commit-bot: I haz the power, 2016-10-24 04:59:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-24 05:01:53]

Description was changed from

==========
Make editingIgnoresContents() as global function

This patch makes |editingIgnoresContents()| as global function instead of
static member function of template class |EditingStratgegy| since it doesn't
use template parameter to simplify code for improving code health.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Make editingIgnoresContents() as global function

This patch makes |editingIgnoresContents()| as global function instead of
static member function of template class |EditingStratgegy| since it doesn't
use template parameter to simplify code for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Committed: https://crrev.com/d843d2ba859914b09e483c53be80b0150fda0937
Cr-Commit-Position: refs/heads/master@{#427016}
==========

[commit-bot: I haz the power, 2016-10-24 05:01:54]

Patchset 4 (id:??) landed as
https://crrev.com/d843d2ba859914b09e483c53be80b0150fda0937
Cr-Commit-Position: refs/heads/master@{#427016}