Enable fetching of admin policies for login screen apps

chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 82 matching lines @@
 
 class TestingDeviceCloudPolicyManagerChromeOS
     : public DeviceCloudPolicyManagerChromeOS {
  public:
   TestingDeviceCloudPolicyManagerChromeOS(
       std::unique_ptr<DeviceCloudPolicyStoreChromeOS> store,
       const scoped_refptr<base::SequencedTaskRunner>& task_runner,
       ServerBackedStateKeysBroker* state_keys_broker)
       : DeviceCloudPolicyManagerChromeOS(std::move(store),
                                          task_runner,
-                                         state_keys_broker) {}
+                                         state_keys_broker) {
+    set_is_component_policy_enabled_for_testing(false);
+  }
+
   ~TestingDeviceCloudPolicyManagerChromeOS() override {}
 };
 
 class DeviceCloudPolicyManagerChromeOSTest
     : public chromeos::DeviceSettingsTestBase,
       public DeviceCloudPolicyManagerChromeOS::Observer {
  protected:
   DeviceCloudPolicyManagerChromeOSTest()
       : fake_cryptohome_client_(new chromeos::FakeCryptohomeClient()),
         state_keys_broker_(&fake_session_manager_client_,
@@ skipping 479 matching lines @@
 
     // Process policy store.
     device_settings_test_helper_.set_store_result(store_result_);
     device_settings_test_helper_.FlushStore();
     EXPECT_EQ(device_policy_.GetBlob(),
               device_settings_test_helper_.policy_blob());
 
     if (done_)
       return;
 
+    // Process the second policy refresh, now with component policy types added.
+    MockDeviceManagementJob* component_policy_fetch_job = NULL;
+    EXPECT_CALL(device_management_service_,
+                CreateJob(DeviceManagementRequestJob::TYPE_POLICY_FETCH, _))

[Andrew T Wilson (Slow), 2016/10/28 14:49:56]

I'm somewhat confused - doesn't TestingDeviceCloudPolicyManager turn off
component policy fetching?

[emaxx, 2016/10/31 15:51:20]

Right, the comment was misleading. The second policy refresh actually comes from
the new code in the enrollment completion handler.

+        .Times(AtMost(1))
+        .WillOnce(device_management_service_.CreateAsyncJob(
+            &component_policy_fetch_job));
+    EXPECT_CALL(device_management_service_,
+                StartJob(dm_protocol::kValueRequestPolicy, _, _, _, _, _))
+        .Times(AtMost(1));
+
     // Key installation and policy load.
     device_settings_test_helper_.set_policy_blob(loaded_blob_);
     owner_key_util_->SetPublicKeyFromPrivateKey(
         *device_policy_.GetNewSigningKey());
     ReloadDeviceSettings();
+
+    // Respond to the second policy refresh.
+    if (component_policy_fetch_job) {
+      component_policy_fetch_job->SendResponse(policy_fetch_status_,
+                                               policy_fetch_response_);
+    }
+    Mock::VerifyAndClearExpectations(&device_management_service_);
   }
 
   bool ShouldRegisterWithCert() const override { return GetParam(); }
 
   const std::unique_ptr<em::DeviceRegisterRequest> GetDeviceRegisterRequest() {
     auto req = base::MakeUnique<em::DeviceRegisterRequest>();
     if (ShouldRegisterWithCert()) {
       em::CertificateBasedDeviceRegistrationData data;
       const em::SignedData& signed_request =
           register_request_.certificate_based_register_request()
@@ skipping 181 matching lines @@
                         DeviceCloudPolicyManagerChromeOSEnrollmentTest,
                         ::testing::Values(false, true));
 
 INSTANTIATE_TEST_CASE_P(
     Cert,
     DeviceCloudPolicyManagerChromeOSEnrollmentBlankSystemSaltTest,
     ::testing::Values(false, true));
 
 }  // namespace
 }  // namespace policy