Enable fetching of admin policies for login screen apps

chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/policy/device_cloud_policy_initializer.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 219 matching lines @@
 
 void DeviceCloudPolicyInitializer::EnrollmentCompleted(
     const EnrollmentCallback& enrollment_callback,
     EnrollmentStatus status) {
   std::unique_ptr<CloudPolicyClient> client =
       enrollment_handler_->ReleaseClient();
   enrollment_handler_.reset();
 
   if (status.status() == EnrollmentStatus::STATUS_SUCCESS) {
     StartConnection(std::move(client));
+    // Request policy refresh, as some new policy types (e.g. component
+    // policies) could be added for fetching when the connection was started by
+    // the device cloud policy manager.
+    manager_->RefreshPolicies();

[Andrew T Wilson (Slow), 2016/10/28 14:49:56]

This is fine, but curious why StartConnection() doesn't refresh policies if this
is a known side effect?

[emaxx, 2016/10/31 15:51:20]

Usually the first policy fetch happens as the result of the
DeviceCloudPolicyManagerChromeOS::StartConnection call: it calls
CloudPolicyCore::StartRefreshScheduler which creates a
CloudPolicyRefreshScheduler that schedules an immediate refresh because there's
no previous policy fetch time.

During enrollment, the first policy fetch happens earlier, before calling
DeviceCloudPolicyManagerChromeOS::StartConnection, that's why the new
CloudPolicyRefreshScheduler instance doesn't schedule an immediate policy
refresh.


Though I agree this my solution looks more like a workaround.
Maybe you have an idea for a better approach?

[Andrew T Wilson (Slow), 2016/10/31 20:44:11]

I don't have a great idea here - I've never really had to dive into the
enrollment code so I don't have a deep understanding about how the
initialization order works.

   } else {
     // Some attempts to create a client may be blocked because the enrollment
     // was in progress. We give it a try again.
     TryToCreateClient();
   }
 
   if (!enrollment_callback.is_null())
     enrollment_callback.Run(status);
 }
 
@@ skipping 68 matching lines @@
   if (success && (success = att_signed_data.ParseFromString(signed_data))) {
     em_signed_data.set_data(att_signed_data.data());
     em_signed_data.set_signature(att_signed_data.signature());
     em_signed_data.set_extra_data_bytes(att_signed_data.data().size() -
                                         data.size());
   }
   callback.Run(success, em_signed_data);
 }
 
 }  // namespace policy