Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3266)

Unified Diff: chrome/android/java/AndroidManifest.xml

Issue 2441623002: Split MinidumpUploadService into core- and Chrome-implementation. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/AndroidManifest.xml
diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/AndroidManifest.xml
index f8bdbdff185919cd08a8bd7e7dd5f10f18ef05ee..e53e8e9bae479babdb90b823d5f45a924e915122 100644
--- a/chrome/android/java/AndroidManifest.xml
+++ b/chrome/android/java/AndroidManifest.xml
@@ -768,7 +768,8 @@ by a child template that "extends" this file.
android:exported="false"/>
<service android:name="org.chromium.chrome.browser.crash.MinidumpPreparationService"
android:exported="false"/>
- <service android:name="org.chromium.chrome.browser.crash.MinidumpUploadService"
+ <!-- TODO Could add a test to ensure you can start ChromeMinidumpUploadService through startService... -->
Ilya Sherman 2016/10/21 00:27:27 nit: Is this a TODO that you're intending to commi
gsennton 2016/10/21 13:43:32 I've added ChromeMinidumpUploadServiceTest now :).
+ <service android:name="org.chromium.chrome.browser.crash.ChromeMinidumpUploadService"
android:exported="false"/>
<service android:name="org.chromium.chrome.browser.omaha.OmahaClient"

Powered by Google App Engine
This is Rietveld 408576698