third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp - Issue 2441593002: binding: Returns a reject promise when |this| is not of the type.

Unified Diff: third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp

Issue 2441593002: binding: Returns a reject promise when |this| is not of the type. (Closed)

Patch Set: Updated the test expectation. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp b/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp

index cd0e5e391803f073455e92efc0958ac267c32185..4ccce1202b791a0c969c9aeba2562dde3a7b1624 100644

--- a/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp

@@ -72,7 +72,7 @@ void voidMethodPartial2MethodCallback(const v8::FunctionCallbackInfo<v8::Value>&

} // namespace TestInterface2PartialV8Internal

const V8DOMConfiguration::MethodConfiguration V8TestInterface2Methods[] = {

- {"voidMethodPartial2", TestInterface2PartialV8Internal::voidMethodPartial2MethodCallback, 0, 1, v8::None, V8DOMConfiguration::ExposedToAllScripts, V8DOMConfiguration::OnPrototype},

+ {"voidMethodPartial2", TestInterface2PartialV8Internal::voidMethodPartial2MethodCallback, 0, 1, v8::None, V8DOMConfiguration::ExposedToAllScripts, V8DOMConfiguration::OnPrototype, V8DOMConfiguration::CheckHolder},

};

void V8TestInterface2Partial::installV8TestInterface2Template(v8::Isolate* isolate, const DOMWrapperWorld& world, v8::Local<v8::FunctionTemplate> interfaceTemplate)

@@ -89,7 +89,7 @@ void V8TestInterface2Partial::installV8TestInterface2Template(v8::Isolate* isola

V8DOMConfiguration::installMethods(isolate, world, instanceTemplate, prototypeTemplate, interfaceTemplate, signature, V8TestInterface2Methods, WTF_ARRAY_LENGTH(V8TestInterface2Methods));

if (RuntimeEnabledFeatures::interface2PartialFeatureNameEnabled()) {

- const V8DOMConfiguration::MethodConfiguration voidMethodPartial1MethodConfiguration = {"voidMethodPartial1", TestInterface2PartialV8Internal::voidMethodPartial1MethodCallback, 0, 1, v8::None, V8DOMConfiguration::ExposedToAllScripts, V8DOMConfiguration::OnPrototype};

+ const V8DOMConfiguration::MethodConfiguration voidMethodPartial1MethodConfiguration = {"voidMethodPartial1", TestInterface2PartialV8Internal::voidMethodPartial1MethodCallback, 0, 1, v8::None, V8DOMConfiguration::ExposedToAllScripts, V8DOMConfiguration::OnPrototype, V8DOMConfiguration::CheckHolder};

V8DOMConfiguration::installMethod(isolate, world, instanceTemplate, prototypeTemplate, interfaceTemplate, signature, voidMethodPartial1MethodConfiguration);

}