Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2441573002: Move setNonDirectionalSelectionIfNeeded() to SelectionController from FrameSelection (Closed)
Patch Set: 2016-10-24T17:02:54 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameSelection.h
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.h b/third_party/WebKit/Source/core/editing/FrameSelection.h
index b1bdf3800c54177e10d8f90591099e45e18d31c2..2de303215115bbd5b4000620203231f17b3def4e 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.h
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.h
@@ -249,14 +249,6 @@ class CORE_EXPORT FrameSelection final
void showTreeForThis() const;
#endif
- enum EndPointsAdjustmentMode {
- AdjustEndpointsAtBidiBoundary,
- DoNotAdjustEndpoints
- };
- void setNonDirectionalSelectionIfNeeded(
- const VisibleSelectionInFlatTree&,
- TextGranularity,
- EndPointsAdjustmentMode = DoNotAdjustEndpoints);
void setFocusedNodeIfNeeded();
void notifyLayoutObjectOfSelectionChange(EUserTriggered);
@@ -295,6 +287,7 @@ class CORE_EXPORT FrameSelection final
private:
friend class FrameSelectionTest;
friend class PaintControllerPaintTestForSlimmingPaintV1AndV2;
+ friend class SelectionControllerTest;
FRIEND_TEST_ALL_PREFIXES(PaintControllerPaintTestForSlimmingPaintV1AndV2,
FullDocumentPaintingWithCaret);
@@ -305,11 +298,6 @@ class CORE_EXPORT FrameSelection final
const VisibleSelectionInFlatTree& selectionInFlatTree() const;
template <typename Strategy>
- VisiblePositionTemplate<Strategy> originalBase() const;
- void setOriginalBase(const VisiblePosition&);
- void setOriginalBase(const VisiblePositionInFlatTree&);
-
- template <typename Strategy>
void setSelectionAlgorithm(const VisibleSelectionTemplate<Strategy>&,
SetSelectionOptions,
CursorAlignOnScroll,
@@ -345,8 +333,6 @@ class CORE_EXPORT FrameSelection final
const Member<PendingSelection> m_pendingSelection;
const Member<SelectionEditor> m_selectionEditor;
- // Used to store base before the adjustment at bidi boundary
- VisiblePositionInFlatTree m_originalBaseInFlatTree;
TextGranularity m_granularity;
LayoutUnit m_xPosForVerticalArrowNavigation;
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698