arc: Create intermediate directories in c/b/c/arc

arc: Create intermediate directories in c/b/c/arc

chrome/browser/chromeos/arc directory has become very cluttered. In
preparation for a big refactor, let's create intermediate directories
for most of the files. The ones that are still in the top-level
directory will undergo significant change, so it doesn't make sense to
move them just yet since all their callsites will also need to be
changed soon.

BUG=657687
TEST=git cl try

Committed: https://crrev.com/88cd832f54cd34331040e1489de6a13cfb921922
Cr-Commit-Position: refs/heads/master@{#427250}

[Luis Héctor Chávez, 2016-10-20 02:28:55]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 02:29:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 03:05:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 03:05:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Luis Héctor Chávez, 2016-10-20 03:46:12]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 03:46:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Luis Héctor Chávez, 2016-10-20 05:03:10]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 05:03:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 06:04:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 06:04:58]

Dry run: This issue passed the CQ dry run.

[Luis Héctor Chávez, 2016-10-20 06:44:41]

lhchavez@chromium.org changed reviewers:
+ afakhry@chromium.org, georgesak@chromium.org, hidehiko@chromium.org,
msw@chromium.org, oshima@chromium.org

[Luis Héctor Chávez, 2016-10-20 06:44:42]

PTAL

hidehiko@ arc/*
oshima@ chrome/browser/chromeos
georgesak@ chrome/browser/memory
afakhry@ chrome/browser/task_manager
msw@ chrome/browser/ui

[hidehiko, 2016-10-20 06:57:17]

c/b/c/arc LGTM.

[afakhry, 2016-10-20 18:01:31]

On 2016/10/20 06:57:17, hidehiko wrote:
> c/b/c/arc LGTM.

c/b/task_manager lgtm

[msw, 2016-10-20 20:10:36]

rubber-stamp lgtm for c/b/ui include path updates.

[Yusuke Sato, 2016-10-20 20:49:02]

yusukes@chromium.org changed reviewers:
+ yusukes@chromium.org

[Yusuke Sato, 2016-10-20 20:49:04]

lgtm with some requests:

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/BUILD.gn (right):

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All
rights reserved.
This might be a good opportunity to have c/b/c/arc/BUILD.gn (in a separate CL).
WDYT?

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/settings/arc_settings_service.h (right):

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/settings/arc_settings_service.h:5: #ifndef
CHROME_BROWSER_CHROMEOS_ARC_SETTINGS_ARC_SETTINGS_SERVICE_H_
Can you use c/b/c/arc/intent_helper/? Conceptually this is just a part of
c/arc/intent_helper/ but lives in c/b/c/arc/ because of its dependency on Chrome
profile.

Roughly speaking, others are moved based on the mojom interface name (e.g.
policy, print, process) they use, right? This one uses intent_helper().

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/ui/arc_external_protocol_dialog.h (right):

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/ui/arc_external_protocol_dialog.h:5: #ifndef
CHROME_BROWSER_CHROMEOS_ARC_UI_ARC_EXTERNAL_PROTOCOL_DIALOG_H_
This can live in c/b/c/arc/intent_helper/ too.

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/ui/arc_navigation_throttle.h (right):

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/ui/arc_navigation_throttle.h:5: #ifndef
CHROME_BROWSER_CHROMEOS_ARC_UI_ARC_NAVIGATION_THROTTLE_H_
This one does not have any code that directly manipulates UI actually. This just
intercepts network requests Chrome makes and forward them to intent_helper() as
needed. Can you move this to c/b/c/arc/intent_helper/ as well?

Also, please land this after https://codereview.chromium.org/2436923002/ lands.
https://codereview.chromium.org/2436923002/ has to be merged to M55.

[Luis Héctor Chávez, 2016-10-20 22:29:36]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 22:30:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Luis Héctor Chávez, 2016-10-20 22:30:23]

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/BUILD.gn (right):

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All
rights reserved.
On 2016/10/20 20:49:03, Yusuke Sato wrote:
> This might be a good opportunity to have c/b/c/arc/BUILD.gn (in a separate
CL).
> WDYT?

SGTM. Ack.

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/settings/arc_settings_service.h (right):

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/settings/arc_settings_service.h:5: #ifndef
CHROME_BROWSER_CHROMEOS_ARC_SETTINGS_ARC_SETTINGS_SERVICE_H_
On 2016/10/20 20:49:03, Yusuke Sato wrote:
> Can you use c/b/c/arc/intent_helper/? Conceptually this is just a part of
> c/arc/intent_helper/ but lives in c/b/c/arc/ because of its dependency on
Chrome
> profile.
> 
> Roughly speaking, others are moved based on the mojom interface name (e.g.
> policy, print, process) they use, right? This one uses intent_helper().
> 

Done.

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/ui/arc_external_protocol_dialog.h (right):

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/ui/arc_external_protocol_dialog.h:5: #ifndef
CHROME_BROWSER_CHROMEOS_ARC_UI_ARC_EXTERNAL_PROTOCOL_DIALOG_H_
On 2016/10/20 20:49:03, Yusuke Sato wrote:
> This can live in c/b/c/arc/intent_helper/ too.

Done.

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/ui/arc_navigation_throttle.h (right):

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/ui/arc_navigation_throttle.h:5: #ifndef
CHROME_BROWSER_CHROMEOS_ARC_UI_ARC_NAVIGATION_THROTTLE_H_
On 2016/10/20 20:49:04, Yusuke Sato wrote:
> This one does not have any code that directly manipulates UI actually. This
just
> intercepts network requests Chrome makes and forward them to intent_helper()
as
> needed. Can you move this to c/b/c/arc/intent_helper/ as well?
> 
> Also, please land this after https://codereview.chromium.org/2436923002/
lands.
> https://codereview.chromium.org/2436923002/ has to be merged to M55.

Done.

[Yusuke Sato, 2016-10-20 22:50:18]

Thanks! one nit:

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/settings/arc_settings_service.h (right):

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/settings/arc_settings_service.h:5: #ifndef
CHROME_BROWSER_CHROMEOS_ARC_SETTINGS_ARC_SETTINGS_SERVICE_H_
On 2016/10/20 22:30:22, Luis Héctor Chávez wrote:
> On 2016/10/20 20:49:03, Yusuke Sato wrote:
> > Can you use c/b/c/arc/intent_helper/? Conceptually this is just a part of
> > c/arc/intent_helper/ but lives in c/b/c/arc/ because of its dependency on
> Chrome
> > profile.
> > 
> > Roughly speaking, others are moved based on the mojom interface name (e.g.
> > policy, print, process) they use, right? This one uses intent_helper().
> > 
> 
> Done.

Not yet done probably? Could you move settings/* to intent_helper/* ?

[Luis Héctor Chávez, 2016-10-20 23:00:43]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 23:02:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Luis Héctor Chávez, 2016-10-20 23:03:04]

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/settings/arc_settings_service.h (right):

https://codereview.chromium.org/2441563002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/settings/arc_settings_service.h:5: #ifndef
CHROME_BROWSER_CHROMEOS_ARC_SETTINGS_ARC_SETTINGS_SERVICE_H_
On 2016/10/20 22:50:18, Yusuke Sato wrote:
> On 2016/10/20 22:30:22, Luis Héctor Chávez wrote:
> > On 2016/10/20 20:49:03, Yusuke Sato wrote:
> > > Can you use c/b/c/arc/intent_helper/? Conceptually this is just a part of
> > > c/arc/intent_helper/ but lives in c/b/c/arc/ because of its dependency on
> > Chrome
> > > profile.
> > > 
> > > Roughly speaking, others are moved based on the mojom interface name (e.g.
> > > policy, print, process) they use, right? This one uses intent_helper().
> > > 
> > 
> > Done.
> 
> Not yet done probably? Could you move settings/* to intent_helper/* ?

argh, did not amend the commit. now it's really done.

[Yusuke Sato, 2016-10-20 23:12:58]

lgtm++

[commit-bot: I haz the power, 2016-10-21 01:21:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 01:21:39]

Dry run: This issue passed the CQ dry run.

[Georges Khalil, 2016-10-24 13:45:59]

chrome/browser/memory/ LGTM

[Luis Héctor Chávez, 2016-10-24 15:50:40]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 15:51:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 15:54:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 15:54:41]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Luis Héctor Chávez, 2016-10-24 16:15:12]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 16:15:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 18:53:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 18:53:28]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-10-25 00:40:47]

rs lgtm

[Luis Héctor Chávez, 2016-10-25 00:44:17]

The CQ bit was checked by lhchavez@chromium.org

[Luis Héctor Chávez, 2016-10-25 00:44:18]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
hidehiko@chromium.org, afakhry@chromium.org, georgesak@chromium.org,
yusukes@chromium.org
Link to the patchset: https://codereview.chromium.org/2441563002/#ps120001
(title: "Rebase to ToT")

[commit-bot: I haz the power, 2016-10-25 00:45:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 00:52:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 00:52:19]

Failed to apply patch for
chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle_unittest.cc:
While running git apply --index -3 -p1;
  error: patch failed:
chrome/browser/chromeos/arc/arc_navigation_throttle_unittest.cc:2
  Falling back to three-way merge...
  Applied patch to
'chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle_unittest.cc'
with conflicts.
  U
chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle_unittest.cc

Patch:   NR 
chrome/browser/chromeos/arc/arc_navigation_throttle_unittest.cc->chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle_unittest.cc
Index:
chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle_unittest.cc
diff --git a/chrome/browser/chromeos/arc/arc_navigation_throttle_unittest.cc
b/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle_unittest.cc
similarity index 96%
rename from chrome/browser/chromeos/arc/arc_navigation_throttle_unittest.cc
rename to
chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle_unittest.cc
index
759a2556d52aed6728419f39f72b657e2bf96e0e..b5164598119e67f57bc674f9a50355b41d17d9cf
100644
--- a/chrome/browser/chromeos/arc/arc_navigation_throttle_unittest.cc
+++
b/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle_unittest.cc
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/chromeos/arc/arc_navigation_throttle.h"
+#include "chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"

[Luis Héctor Chávez, 2016-10-25 01:16:26]

The CQ bit was checked by lhchavez@chromium.org

[Luis Héctor Chávez, 2016-10-25 01:16:27]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
georgesak@chromium.org, msw@chromium.org, hidehiko@chromium.org,
afakhry@chromium.org, yusukes@chromium.org
Link to the patchset: https://codereview.chromium.org/2441563002/#ps140001
(title: "Re-rebase to ToT")

[commit-bot: I haz the power, 2016-10-25 01:16:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 02:45:28]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-10-25 02:47:18]

Description was changed from

==========
arc: Create intermediate directories in c/b/c/arc

chrome/browser/chromeos/arc directory has become very cluttered. In
preparation for a big refactor, let's create intermediate directories
for most of the files. The ones that are still in the top-level
directory will undergo significant change, so it doesn't make sense to
move them just yet since all their callsites will also need to be
changed soon.

BUG=657687
TEST=git cl try
==========

to

==========
arc: Create intermediate directories in c/b/c/arc

chrome/browser/chromeos/arc directory has become very cluttered. In
preparation for a big refactor, let's create intermediate directories
for most of the files. The ones that are still in the top-level
directory will undergo significant change, so it doesn't make sense to
move them just yet since all their callsites will also need to be
changed soon.

BUG=657687
TEST=git cl try

Committed: https://crrev.com/88cd832f54cd34331040e1489de6a13cfb921922
Cr-Commit-Position: refs/heads/master@{#427250}
==========

[commit-bot: I haz the power, 2016-10-25 02:47:20]

Patchset 8 (id:??) landed as
https://crrev.com/88cd832f54cd34331040e1489de6a13cfb921922
Cr-Commit-Position: refs/heads/master@{#427250}