RTCStats equality operator added

webrtc/stats/rtcstats.cc

 /*
  *  Copyright 2016 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 30 matching lines @@
   oss << "{ \"" << rtc::ToString<T>(strings[0]) << '\"';
   for (size_t i = 1; i < strings.size(); ++i) {
     oss << ", \"" << rtc::ToString<T>(strings[i]) << '\"';
   }
   oss << " }";
   return oss.str();
 }
 
 }  // namespace
 
+bool RTCStats::operator==(const RTCStats& other) const {
+  if (type() != other.type())
+    return false;
+  std::vector<const RTCStatsMemberInterface*> members = Members();

[hta-webrtc, 2016/10/21 08:56:01]

What about the id and the timestamp?

Are they significant for equality, or are they not?
If they aren't, this needs to be prominently explained in the .h file.

[hbos_chromium, 2016/10/21 18:59:18]

They should also be compared too, fixed that. Done.

+  std::vector<const RTCStatsMemberInterface*> other_members = other.Members();
+  RTC_DCHECK_EQ(members.size(), other_members.size());
+  for (size_t i = 0; i < members.size(); ++i) {
+    const RTCStatsMemberInterface* member = members[i];
+    const RTCStatsMemberInterface* other_member = other_members[i];
+    RTC_DCHECK_EQ(member->type(), other_member->type());
+    RTC_DCHECK_EQ(member->name(), other_member->name());
+    if (*member != *other_member)
+      return false;
+  }
+  return true;
+}
+
+bool RTCStats::operator!=(const RTCStats& other) const {
+  return !(*this == other);
+}
+
 std::string RTCStats::ToString() const {
   std::ostringstream oss;
   oss << type() << " {\n  id: \"" << id_ << "\"\n  timestamp: "
       << timestamp_us_ << '\n';
   for (const RTCStatsMemberInterface* member : Members()) {
     oss << "  " << member->name() << ": ";
     if (member->is_defined()) {
       if (member->is_string())
         oss << '"' << member->ValueToString() << "\"\n";
       else
@@ skipping 62 matching lines @@
     std::vector<uint64_t>, kSequenceUint64, true, false,
     VectorToString(value_));
 WEBRTC_DEFINE_RTCSTATSMEMBER(
     std::vector<double>, kSequenceDouble, true, false,
     VectorToString(value_));
 WEBRTC_DEFINE_RTCSTATSMEMBER(
     std::vector<std::string>, kSequenceString, true, false,
     VectorOfStringsToString(value_));
 
 }  // namespace webrtc