chrome/browser/resources/print_preview/settings/copies_settings.html - Issue 2441493004: Add copies changes to prepare for scaling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/settings/copies_settings.html

Issue 2441493004: Add copies changes to prepare for scaling (Closed)

Patch Set: Fix test breakage Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/settings/copies_settings.css ('k') | chrome/browser/resources/print_preview/settings/copies_settings.js » ('j') | chrome/browser/resources/print_preview/settings/simple_settings_box.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/settings/copies_settings.html

diff --git a/chrome/browser/resources/print_preview/settings/copies_settings.html b/chrome/browser/resources/print_preview/settings/copies_settings.html

index 42c7bff00c12ff356055176020e805997541d87e..297681e4af1546abb5093f41ea20b45cf838fc93 100644

--- a/chrome/browser/resources/print_preview/settings/copies_settings.html

+++ b/chrome/browser/resources/print_preview/settings/copies_settings.html

@@ -1,24 +1,19 @@

- <h1 id="copies-label" i18n-content="copiesLabel"></h1>

+ <h1 id="copies-label">$i18n{copiesLabel}</h1>

</div>

- <div id="copies-settings-box">

- <input class="copies" type="text" value="1" maxlength="3"

+ <div class="simple-settings-box" id="copies-settings-box">

+ <input class="user-value" type="number" value="1" maxlength="3"

+ max="999" min="1"

aria-labelledby="copies-label" aria-live="polite" id="copies">

- <button class="increment"

- i18n-values="title:incrementTitle;aria-label:incrementTitle"

dpapad 2016/10/20 22:36:06 Are the incrementTitle/decrementTitle string neede

rbpotter 2016/10/20 23:03:37 Done.

- aria-controls="copies">+</button>

- <button class="decrement"

- i18n-values="title:decrementTitle;aria-label:decrementTitle"

- aria-controls="copies">–</button>

<input class="collate" type="checkbox" checked

aria-labelledby="copies-collate-label">

- <span id="copies-collate-label" i18n-content="optionCollate"></span>

+ <span id="copies-collate-label">$i18n{optionCollate}</span>

</label></div>

</div>

- <span class="hint" i18n-content="copiesInstruction" aria-live="polite">

+ <span class="hint" aria-live="polite">$i18n{copiesInstruction}</span>

</span>

</div>