Add copies changes to prepare for scaling

Print preview: Convert copies settings section to native input type=number
field.

Separates formatting of the number field into a separate CSS file to
prepare for addition of scaling, which will use the same field.

BUG=96456
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ee33e4e0e8e7da42e4f7cae338da35e851b300fa
Cr-Commit-Position: refs/heads/master@{#426691}

[rbpotter, 2016-10-20 21:00:57]

Description was changed from

==========
Add copies changes to prepare for scaling
Convert copies settings section to native input type=number field.
Separates formatting of the number field into a separate CSS file to
prepare for addition of scaling, which will use the same field.

BUG=
==========

to

==========
Add copies changes to prepare for scaling
Convert copies settings section to native input type=number field.
Separates formatting of the number field into a separate CSS file to
prepare for addition of scaling, which will use the same field.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[rbpotter, 2016-10-20 21:01:21]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 21:02:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rbpotter, 2016-10-20 21:11:48]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[rbpotter, 2016-10-20 21:12:37]

Description was changed from

==========
Add copies changes to prepare for scaling
Convert copies settings section to native input type=number field.
Separates formatting of the number field into a separate CSS file to
prepare for addition of scaling, which will use the same field.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add copies changes to prepare for scaling
Convert copies settings section to native input type=number field.
Separates formatting of the number field into a separate CSS file to
prepare for addition of scaling, which will use the same field.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[rbpotter, 2016-10-20 21:12:37]

rbpotter@chromium.org changed reviewers:
+ dpapad@chromium.org

[commit-bot: I haz the power, 2016-10-20 21:12:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rbpotter, 2016-10-20 21:24:56]

Copies changes only CL, to be landed before scaling.

[dpapad, 2016-10-20 22:36:06]

https://codereview.chromium.org/2441493004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/print_preview/settings/copies_settings.html
(left):

https://codereview.chromium.org/2441493004/diff/20001/chrome/browser/resource...
chrome/browser/resources/print_preview/settings/copies_settings.html:10:
i18n-values="title:incrementTitle;aria-label:incrementTitle"
Are the incrementTitle/decrementTitle string needed anymore? If not let's remove
them completely, from
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/print_preview/pr...
and corresponding grd file.

https://codereview.chromium.org/2441493004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/print_preview/settings/simple_settings_box.css
(right):

https://codereview.chromium.org/2441493004/diff/20001/chrome/browser/resource...
chrome/browser/resources/print_preview/settings/simple_settings_box.css:5:
.simple-settings-box input.user-value.invalid {
Now that the UX change got approved, we don't need the differentiation between
settings-box and simple-settings-box, so how about we rename this file and the
CSS class to settings-box?

[commit-bot: I haz the power, 2016-10-20 22:48:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 22:48:06]

Dry run: This issue passed the CQ dry run.

[rbpotter, 2016-10-20 22:57:07]

Patchset #3 (id:40001) has been deleted

[rbpotter, 2016-10-20 22:57:25]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 22:57:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rbpotter, 2016-10-20 23:03:38]

https://codereview.chromium.org/2441493004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/print_preview/settings/copies_settings.html
(left):

https://codereview.chromium.org/2441493004/diff/20001/chrome/browser/resource...
chrome/browser/resources/print_preview/settings/copies_settings.html:10:
i18n-values="title:incrementTitle;aria-label:incrementTitle"
On 2016/10/20 22:36:06, dpapad wrote:
> Are the incrementTitle/decrementTitle string needed anymore? If not let's
remove
> them completely, from
>
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/print_preview/pr...
> and corresponding grd file.

Done.

https://codereview.chromium.org/2441493004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/print_preview/settings/simple_settings_box.css
(right):

https://codereview.chromium.org/2441493004/diff/20001/chrome/browser/resource...
chrome/browser/resources/print_preview/settings/simple_settings_box.css:5:
.simple-settings-box input.user-value.invalid {
On 2016/10/20 22:36:06, dpapad wrote:
> Now that the UX change got approved, we don't need the differentiation between
> settings-box and simple-settings-box, so how about we rename this file and the
> CSS class to settings-box?

Done.

[dpapad, 2016-10-20 23:15:54]

LGTM, sans comments below.

Also the first line of the CL description is the most important one. Can you
rephrase as follows.

"Print preview: Convert copies settings section to native input type=number
field.

Separates formatting of the number field into a separate CSS file to
prepare for addition of scaling, which will use the same field."

https://codereview.chromium.org/2441493004/diff/60001/chrome/browser/resource...
File chrome/browser/resources/print_preview/settings/copies_settings.js (right):

https://codereview.chromium.org/2441493004/diff/60001/chrome/browser/resource...
chrome/browser/resources/print_preview/settings/copies_settings.js:1: //
Copyright (c) 2016 The Chromium Authors. All rights reserved.
I don't think the year needs to be updated.

https://codereview.chromium.org/2441493004/diff/60001/chrome/browser/resource...
File chrome/browser/resources/print_preview/settings/settings_box.css (right):

https://codereview.chromium.org/2441493004/diff/60001/chrome/browser/resource...
chrome/browser/resources/print_preview/settings/settings_box.css:5:
.settings-box input.user-value.invalid {
Need to refer to this file from print_preview.html, no?

[dpapad, 2016-10-20 23:16:42]

Also, since you did this change as part of implementing the "print scaling",
let's add a BUG= to this CL.

[rbpotter, 2016-10-20 23:20:40]

Description was changed from

==========
Add copies changes to prepare for scaling
Convert copies settings section to native input type=number field.
Separates formatting of the number field into a separate CSS file to
prepare for addition of scaling, which will use the same field.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Print preview: Convert copies settings section to native input type=number
field.

Separates formatting of the number field into a separate CSS file to
prepare for addition of scaling, which will use the same field.

BUG=96456
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[rbpotter, 2016-10-20 23:37:16]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 23:37:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rbpotter, 2016-10-20 23:38:31]

https://codereview.chromium.org/2441493004/diff/60001/chrome/browser/resource...
File chrome/browser/resources/print_preview/settings/copies_settings.js (right):

https://codereview.chromium.org/2441493004/diff/60001/chrome/browser/resource...
chrome/browser/resources/print_preview/settings/copies_settings.js:1: //
Copyright (c) 2016 The Chromium Authors. All rights reserved.
On 2016/10/20 23:15:54, dpapad wrote:
> I don't think the year needs to be updated.

Done.

https://codereview.chromium.org/2441493004/diff/60001/chrome/browser/resource...
File chrome/browser/resources/print_preview/settings/settings_box.css (right):

https://codereview.chromium.org/2441493004/diff/60001/chrome/browser/resource...
chrome/browser/resources/print_preview/settings/settings_box.css:5:
.settings-box input.user-value.invalid {
On 2016/10/20 23:15:54, dpapad wrote:
> Need to refer to this file from print_preview.html, no?

Done.

[commit-bot: I haz the power, 2016-10-21 01:41:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 01:42:00]

Dry run: This issue passed the CQ dry run.

[rbpotter, 2016-10-21 02:06:20]

The CQ bit was checked by rbpotter@chromium.org

[rbpotter, 2016-10-21 02:06:20]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2441493004/#ps80001
(title: "Fix final issues")

[commit-bot: I haz the power, 2016-10-21 02:06:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 02:20:12]

Description was changed from

==========
Print preview: Convert copies settings section to native input type=number
field.

Separates formatting of the number field into a separate CSS file to
prepare for addition of scaling, which will use the same field.

BUG=96456
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Print preview: Convert copies settings section to native input type=number
field.

Separates formatting of the number field into a separate CSS file to
prepare for addition of scaling, which will use the same field.

BUG=96456
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-21 02:20:13]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-10-21 13:26:11]

Description was changed from

==========
Print preview: Convert copies settings section to native input type=number
field.

Separates formatting of the number field into a separate CSS file to
prepare for addition of scaling, which will use the same field.

BUG=96456
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Print preview: Convert copies settings section to native input type=number
field.

Separates formatting of the number field into a separate CSS file to
prepare for addition of scaling, which will use the same field.

BUG=96456
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ee33e4e0e8e7da42e4f7cae338da35e851b300fa
Cr-Commit-Position: refs/heads/master@{#426691}
==========

[commit-bot: I haz the power, 2016-10-21 13:26:12]

Patchset 4 (id:??) landed as
https://crrev.com/ee33e4e0e8e7da42e4f7cae338da35e851b300fa
Cr-Commit-Position: refs/heads/master@{#426691}