Use a standard message box for DesktopCastingWarningView.

components/constrained_window/constrained_window_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/constrained_window/constrained_window_views.h"
 
 #include <algorithm>
 
 #include "base/macros.h"
 #include "build/build_config.h"
@@ skipping 183 matching lines @@
           ->delegate()
           ->GetWebContentsModalDialogHost()
           ->GetHostView());
 }
 
 views::Widget* CreateBrowserModalDialogViews(views::DialogDelegate* dialog,
                                              gfx::NativeWindow parent) {
   DCHECK_NE(ui::MODAL_TYPE_CHILD, dialog->GetModalType());
   DCHECK_NE(ui::MODAL_TYPE_NONE, dialog->GetModalType());
 
-  DCHECK(constrained_window_views_client);
+  if (parent)
+    DCHECK(constrained_window_views_client);

[msw, 2016/10/27 21:46:45]

Double checking that this works okay (ie. DCHECK resolve to an empty statement
when off and this doesn't need curly braces). You could just do DCHECK(!parent
|| constrained_window_views_client)?

[Evan Stade, 2016/10/28 17:31:55]

yes, it works. If it didn't, wouldn't the release build fail due to parent_view
scoping?
I thought that was less descriptive since you wouldn't know which arm had
failed, but now that I think about it I guess it's the same since both arms must
fail for the dcheck to fail.

   gfx::NativeView parent_view =
       parent ? constrained_window_views_client->GetDialogHostView(parent)
              : nullptr;
   views::Widget* widget =
       views::DialogDelegate::CreateDialogWidget(dialog, NULL, parent_view);
 
   bool requires_positioning = dialog->ShouldUseCustomFrame();
 
 #if defined(OS_MACOSX)
   // On Mac, window modal dialogs are displayed as sheets, so their position is
   // managed by the parent window.
   requires_positioning = false;
 #endif
 
   if (!requires_positioning)
     return widget;
 
-  ModalDialogHost* host = constrained_window_views_client->
-      GetModalDialogHost(parent);
+  ModalDialogHost* host =
+      parent ? constrained_window_views_client->GetModalDialogHost(parent)
+             : nullptr;
   if (host) {
     DCHECK_EQ(parent_view, host->GetHostView());
     ModalDialogHostObserver* dialog_host_observer =
         new WidgetModalDialogHostObserverViews(
             host, widget, kWidgetModalDialogHostObserverViewsKey);
     dialog_host_observer->OnPositionRequiresUpdate();
   }
   return widget;
 }
 
 }  // namespace constrained window