Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Unified Diff: third_party/WebKit/Source/modules/mediasession/MediaSession.cpp

Issue 2441403002: Add media controls in media notification (Closed)
Patch Set: nits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediasession/MediaSession.cpp
diff --git a/third_party/WebKit/Source/modules/mediasession/MediaSession.cpp b/third_party/WebKit/Source/modules/mediasession/MediaSession.cpp
index af2ae8f94ff1df8ff4f934ebf11ab2582ddd4785..d896e76d6188d67ee60585c9a7fbef59b21ea87f 100644
--- a/third_party/WebKit/Source/modules/mediasession/MediaSession.cpp
+++ b/third_party/WebKit/Source/modules/mediasession/MediaSession.cpp
@@ -12,6 +12,7 @@
#include "modules/EventTargetModules.h"
#include "modules/mediasession/MediaMetadata.h"
#include "modules/mediasession/MediaMetadataSanitizer.h"
+#include "platform/UserGestureIndicator.h"
#include "public/platform/InterfaceProvider.h"
#include "wtf/Optional.h"
#include <memory>
@@ -148,6 +149,7 @@ bool MediaSession::removeEventListenerInternal(
void MediaSession::DidReceiveAction(
blink::mojom::blink::MediaSessionAction action) {
+ UserGestureIndicator gestureIndicator(UserGestureToken::create());
whywhat 2016/10/24 20:54:01 Have you checked this actually sets the user gestu
mlamouri (slow - plz ping) 2016/10/25 10:38:13 I think dispatchEvent() is sync, see EventTarget::
dispatchEvent(Event::create(mojomActionToEventName(action)));
}

Powered by Google App Engine
This is Rietveld 408576698