Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2441363002: Convert editing/selection/5497643.html to use assert_selection() (Closed)

Created:
4 years, 1 month ago by yosin_UTC9
Modified:
4 years, 1 month ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/selection/5497643.html to use assert_selection() This patch converts "editing/selection/5497643.html" to use |assert_selection()| to simplify test case and renames to "after-removing-textarea.html" to provide a hint what this test verifies for improving code health. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/8104e686bae6f7efc882cee49a7e0d560e80fabc Cr-Commit-Position: refs/heads/master@{#427215}

Patch Set 1 : 2016-10-24T18:04:56 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -22 lines) Patch
D third_party/WebKit/LayoutTests/editing/selection/5497643.html View 1 chunk +0 lines, -17 lines 0 comments Download
A + third_party/WebKit/LayoutTests/editing/selection/after-removing-textarea.html View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
yosin_UTC9
PTAL
4 years, 1 month ago (2016-10-24 09:32:42 UTC) #5
Xiaocheng
Please mention the renaming in the patch description.
4 years, 1 month ago (2016-10-24 11:55:49 UTC) #8
yosin_UTC9
PTAL Update description to mention about renaming.
4 years, 1 month ago (2016-10-25 01:19:59 UTC) #10
Xiaocheng
lgtm
4 years, 1 month ago (2016-10-25 01:24:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441363002/1
4 years, 1 month ago (2016-10-25 01:24:56 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 01:29:35 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 01:31:44 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8104e686bae6f7efc882cee49a7e0d560e80fabc
Cr-Commit-Position: refs/heads/master@{#427215}

Powered by Google App Engine
This is Rietveld 408576698