Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2441353003: [wasm] Set externally passed memory non neuterable (Closed)

Created:
4 years, 1 month ago by Clemens Hammacher
Modified:
4 years, 1 month ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Set externally passed memory non neuterable If at instantiation we get an existing ArrayBuffer, set it non neuterable, because we embed the backing memory address in wasm code. With this fix, all tests pass if validate-asm is set to default=true. R=titzer@chromium.org BUG=v8:4203 Committed: https://crrev.com/ef7e896d2a9caad3ae7da4f53bd1c2c2d7921021 Cr-Commit-Position: refs/heads/master@{#40536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/wasm/wasm-module.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Clemens Hammacher
4 years, 1 month ago (2016-10-24 14:14:16 UTC) #3
titzer
lgtm
4 years, 1 month ago (2016-10-24 14:17:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441353003/1
4 years, 1 month ago (2016-10-24 14:40:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 14:44:46 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:11:16 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef7e896d2a9caad3ae7da4f53bd1c2c2d7921021
Cr-Commit-Position: refs/heads/master@{#40536}

Powered by Google App Engine
This is Rietveld 408576698