Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5403)

Unified Diff: chrome/browser/ui/webui/options/font_settings_utils.h

Issue 2441343003: Allow the default generic font family settings to find the first available font (Closed)
Patch Set: Un-shared FirstAvailableOrFirst as per msw review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/font_settings_utils.h
diff --git a/chrome/browser/ui/webui/options/font_settings_utils.h b/chrome/browser/ui/webui/options/font_settings_utils.h
index b800f25cfd1bd03d1b6b6bc6bafd60e5fd94b716..3357019661265b37cc2b53fd6107f0c45266803a 100644
--- a/chrome/browser/ui/webui/options/font_settings_utils.h
+++ b/chrome/browser/ui/webui/options/font_settings_utils.h
@@ -5,6 +5,8 @@
#ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_FONT_SETTINGS_UTILS_H_
#define CHROME_BROWSER_UI_WEBUI_OPTIONS_FONT_SETTINGS_UTILS_H_
+#include <string>
+
#include "base/macros.h"
class PrefService;
@@ -16,6 +18,16 @@ class FontSettingsUtilities {
public:
static void ValidateSavedFonts(PrefService* prefs);
+ // Returns the first available font if it starts with ",".
msw 2016/10/27 00:04:18 This doesn't actually return a font, can you clari
kojii 2016/10/27 04:50:56 Clarified. This function returns the specified nam
+ // Unlike gfx::FontList, this function picks one font, and character-level
+ // fallback is handled in CSS.
+ static std::string ResolveFontList(const std::string&);
msw 2016/10/27 00:04:18 nit: add param names here and below.
kojii 2016/10/27 04:50:56 Done.
+
+ // Returns the localized name of a font so that settings can find it within
+ // the list of system fonts. On Windows, the list of system fonts has names
+ // only for the system locale, but the pref value may be in the English name.
+ static std::string MaybeGetLocalizedFontName(const std::string&);
+
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(FontSettingsUtilities);
};

Powered by Google App Engine
This is Rietveld 408576698