third_party/WebKit/Source/platform/fonts/FontCacheTest.cpp - Issue 2441343003: Allow the default generic font family settings to find the first available font

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/FontCacheTest.cpp

Issue 2441343003: Allow the default generic font family settings to find the first available font (Closed)

Patch Set: Add more tests Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/FontCacheTest.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/FontCacheTest.cpp b/third_party/WebKit/Source/platform/fonts/FontCacheTest.cpp

index 5eeaa67825c3a4ce757ea3384c856d2bd03f4be7..d23e3506b849f2939214303ad33dc9798d510742 100644

--- a/third_party/WebKit/Source/platform/fonts/FontCacheTest.cpp

+++ b/third_party/WebKit/Source/platform/fonts/FontCacheTest.cpp

@@ -35,4 +35,11 @@ TEST(FontCache, getLastResortFallbackFont) {

EXPECT_TRUE(fontData);

}

+TEST(FontCache, firstAvailableOrFirst) {

+ EXPECT_TRUE(FontCache::firstAvailableOrFirst("").isEmpty());

+ EXPECT_TRUE(FontCache::firstAvailableOrFirst(String()).isEmpty());

+ EXPECT_EQ("Arial", FontCache::firstAvailableOrFirst("not exist, Arial"));

} // namespace blink