Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2709)

Unified Diff: chrome/browser/android/chrome_feature_list.cc

Issue 2441243003: Use feature architecture as kill switch for WebAPKs instead of field trial (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/chrome_feature_list.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/chrome_feature_list.cc
diff --git a/chrome/browser/android/chrome_feature_list.cc b/chrome/browser/android/chrome_feature_list.cc
index 0f9705fff70df981df9e574da2e46e6981fdf8a7..43c932be459aa50f621294e9ca05946a22b91314 100644
--- a/chrome/browser/android/chrome_feature_list.cc
+++ b/chrome/browser/android/chrome_feature_list.cc
@@ -51,6 +51,7 @@ const base::Feature* kFeaturesExposedToJava[] = {
&kSpecialLocaleFeature,
&kSpecialLocaleWrapper,
&kTabReparenting,
+ &kWebApk,
&kCCTExternalLinkHandling,
&offline_pages::kOfflinePagesBackgroundLoadingFeature,
&offline_pages::kBackgroundLoaderForDownloadsFeature,
@@ -103,6 +104,12 @@ const base::Feature kCCTExternalLinkHandling{"CCTExternalLinkHandling",
const base::Feature kUserMediaScreenCapturing{
"UserMediaScreenCapturing", base::FEATURE_DISABLED_BY_DEFAULT};
+// Makes "Add to Home screen" in the app menu generate an APK for the shortcut
+// URL which opens Chrome in fullscreen.
+// For WebAPKs to be enabled, the WebAPK feature must be enabled and the
dominickn 2016/10/24 04:04:17 Is it strictly necessary for the feature to be ena
+// --enable-webapk command line flag must be set.
+const base::Feature kWebApk{"WebAPK", base::FEATURE_ENABLED_BY_DEFAULT};
+
static jboolean IsEnabled(JNIEnv* env,
const JavaParamRef<jclass>& clazz,
const JavaParamRef<jstring>& jfeature_name) {
« no previous file with comments | « chrome/browser/android/chrome_feature_list.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698