Add field trial for the WebAPK server URL

chrome/browser/android/webapk/webapk_installer_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/webapk/webapk_installer.h"
 
 #include <jni.h>

[dominickn, 2016/10/27 00:36:26]

Nit: #include <map>

 #include <memory>
 #include <string>
 
+#include "base/android/field_trial_list.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/bind.h"
 #include "base/callback_forward.h"
-#include "base/command_line.h"
+#include "base/feature_list.h"
 #include "base/files/file_path.h"
+#include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/run_loop.h"
 #include "base/single_thread_task_runner.h"
+#include "base/test/scoped_feature_list.h"
 #include "base/threading/thread_task_runner_handle.h"
+#include "chrome/browser/android/chrome_feature_list.h"
 #include "chrome/browser/android/shortcut_info.h"
 #include "chrome/browser/android/webapk/webapk.pb.h"
 #include "chrome/common/chrome_switches.h"
+#include "components/variations/variations_associated_data.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "net/test/embedded_test_server/http_request.h"
 #include "net/test/embedded_test_server/http_response.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "url/gurl.h"
 
 namespace {
 
 const base::FilePath::CharType kTestDataDir[] =
     FILE_PATH_LITERAL("chrome/test/data");
 
+// Mock field trial name and field trial group to use for "WebApks" feature.
+const char kFieldTrialName[] = "MockFieldTrial";
+const char kFieldTrialGroup[] = "MockFieldTrialGroup";
+
 // URL of mock WebAPK server.
 const char* kServerUrl = "/webapkserver/";
 
 // Icon URL from Web Manifest. We use a random file in the test data directory.
 // Since WebApkInstaller does not try to decode the file as an image it is OK
 // that the file is not an image.
 const char* kIconUrl = "/simple.html";
 
 // URL of file to download from the WebAPK server. We use a random file in the
 // test data directory.
@@ skipping 129 matching lines @@
 
 }  // anonymous namespace
 
 class WebApkInstallerTest : public ::testing::Test {
  public:
   typedef base::Callback<std::unique_ptr<net::test_server::HttpResponse>(void)>
       WebApkResponseBuilder;
 
   WebApkInstallerTest()
       : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP) {}
-  ~WebApkInstallerTest() override {}
+  ~WebApkInstallerTest() override {
+    variations::testing::ClearAllVariationParams();
+  }
 
   void SetUp() override {
     test_server_.AddDefaultHandlers(base::FilePath(kTestDataDir));
     test_server_.RegisterRequestHandler(
         base::Bind(&WebApkInstallerTest::HandleWebApkRequest,
                    base::Unretained(this)));
     ASSERT_TRUE(test_server_.Start());
 
+    field_trial_list_.reset(new base::FieldTrialList(nullptr));
+    base::FieldTrial* field_trial = base::FieldTrialList::CreateFieldTrial(
+        kFieldTrialName, kFieldTrialGroup);
+    std::unique_ptr<base::FeatureList> feature_list =
+        base::MakeUnique<base::FeatureList>();
+    feature_list->RegisterFieldTrialOverride(
+        chrome::android::kWebApks.name,
+        base::FeatureList::OVERRIDE_ENABLE_FEATURE, field_trial);
+    scoped_feature_list_.InitWithFeatureList(std::move(feature_list));
+
     SetDefaults();
   }
 
   // Sets the Web Manifest's icon URL.
   void SetIconUrl(const GURL& icon_url) { icon_url_ = icon_url; }
 
   // Sets the URL to send the webapk::CreateWebApkRequest to. WebApkInstaller
   // should fail if the URL is not |kServerUrl|.
   void SetWebApkServerUrl(const GURL& server_url) {
-    base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
-        switches::kWebApkServerUrl, server_url.spec());
+    variations::testing::ClearAllVariationParams();
+    std::map<std::string, std::string> params;
+    params["ServerUrl"] = server_url.spec();
+    ASSERT_TRUE(variations::AssociateVariationParams(kFieldTrialName,
+                                                     kFieldTrialGroup, params));
   }
 
   // Sets the function that should be used to build the response to the
   // WebAPK creation request.
   void SetWebApkResponseBuilder(const WebApkResponseBuilder& builder) {
     webapk_response_builder_ = builder;
   }
 
   std::unique_ptr<WebApkInstallerRunner> CreateWebApkInstallerRunner() {
     return std::unique_ptr<WebApkInstallerRunner>(
@@ skipping 17 matching lines @@
   std::unique_ptr<net::test_server::HttpResponse> HandleWebApkRequest(
       const net::test_server::HttpRequest& request) {
     return (request.relative_url == kServerUrl)
                ? webapk_response_builder_.Run()
                : std::unique_ptr<net::test_server::HttpResponse>();
   }
 
   content::TestBrowserThreadBundle thread_bundle_;
   net::EmbeddedTestServer test_server_;
 
+  std::unique_ptr<base::FieldTrialList> field_trial_list_;
+  base::test::ScopedFeatureList scoped_feature_list_;
+
   // Web Manifest's icon URL.
   GURL icon_url_;
 
   // Builds response to the WebAPK creation request.
   WebApkResponseBuilder webapk_response_builder_;
 
   DISALLOW_COPY_AND_ASSIGN(WebApkInstallerTest);
 };
 
 // Test installation succeeding.
@@ skipping 68 matching lines @@
   runner->RunInstallWebApk();
   EXPECT_FALSE(runner->success());
 }
 
 // Test update succeeding.
 TEST_F(WebApkInstallerTest, UpdateSuccess) {
   std::unique_ptr<WebApkInstallerRunner> runner = CreateWebApkInstallerRunner();
   runner->RunUpdateWebApk();
   EXPECT_TRUE(runner->success());
 }