Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2441193002: Complain if an embedder fails to provide a vm isolate or isolate snapshot to a VM built without DAR… (Closed)

Created:
4 years, 2 months ago by rmacnak
Modified:
4 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Complain if an embedder fails to provide a vm isolate or isolate snapshot to a VM built without DART_NO_SNAPSHOT. Closes #27649 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/e56d8eef56f52dd7b3746d4d55cf8a651d8797f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M runtime/vm/dart.cc View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 2 months ago (2016-10-21 23:23:48 UTC) #2
siva
lgtm
4 years, 2 months ago (2016-10-21 23:36:22 UTC) #3
rmacnak
4 years, 2 months ago (2016-10-21 23:52:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e56d8eef56f52dd7b3746d4d55cf8a651d8797f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698